-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
It looks like @hackmod hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
* ethereum/EIPs#695 * Original PR is openethereum#6329
[clabot:check] |
It looks like @hackmod signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also drop parity_chainId
in this PR. The original intention to use partiy_
namespace rather than eth_
namespace is because the EIP was not standardized. That concern is apparently already addressed as of now.
eth_chainId
method in JSON-RPC ethereum/EIPs#695This PR copy the original PR #6329 work to support both
eth_chainId
andparity_chainId
temporaryparity_chainId
could be dropped later.eth_chainId
method in JSON-RPC - EIP: Implementeth_chainId
method in JSON-RPC ethereum/EIPs#695 accepted(Aug 22 2017)eth_chainId
PR for Ethereum (geth) - eth,internal: add eth_chainId method to PublicEthereumApi JSONRPC ethereum/go-ethereum#15002, add eth_chainId method ethereum/go-ethereum#17617 merged(9/9)eth_chainId
PR for ETC (classic-geth) - implement 'eth_chainId' JSON-RPC method ethereumproject/go-ethereum#336 merged(Aug 16 2017)parity_chainId
PR - Add RPC eth_chainId for querying the current blockchain chain ID #6329 merged (Aug 18 2017)See also MetaMask/metamask-extension#5552
(Edit: for release note, we need to mention that this replaces
parity_chainId
witheth_chainId
.)