Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Support eth_chainId RPC method #9783

Merged
merged 2 commits into from
Oct 20, 2018

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Oct 19, 2018

This PR copy the original PR #6329 work to support both eth_chainId and parity_chainId temporary

parity_chainId could be dropped later.

See also MetaMask/metamask-extension#5552

(Edit: for release note, we need to mention that this replaces parity_chainId with eth_chainId.)

@parity-cla-bot
Copy link

It looks like @hackmod hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@hackmod
Copy link
Contributor Author

hackmod commented Oct 19, 2018

[clabot:check]

@parity-cla-bot
Copy link

It looks like @hackmod signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@seunlanlege seunlanlege added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Oct 19, 2018
Copy link
Member

@seunlanlege seunlanlege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also drop parity_chainId in this PR. The original intention to use partiy_ namespace rather than eth_ namespace is because the EIP was not standardized. That concern is apparently already addressed as of now.

@sorpaas sorpaas added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Oct 20, 2018
@sorpaas sorpaas merged commit b8da38f into openethereum:master Oct 20, 2018
@5chdn 5chdn added this to the 2.2 milestone Oct 24, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants