-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for incoming transactions #7043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmashuang
previously approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM all issues on my side have been addressed.
danjm
reviewed
Aug 20, 2019
danjm
previously approved these changes
Aug 20, 2019
Gudahtt
reviewed
Aug 20, 2019
Gudahtt
reviewed
Aug 20, 2019
whymarrh
force-pushed
the
fix-incoming-txs
branch
from
August 20, 2019 18:07
42564ae
to
49c0c29
Compare
Gudahtt
reviewed
Aug 20, 2019
whymarrh
force-pushed
the
fix-incoming-txs
branch
from
August 20, 2019 18:22
49c0c29
to
a584e57
Compare
whymarrh
force-pushed
the
fix-incoming-txs
branch
from
August 20, 2019 18:24
a584e57
to
1254019
Compare
Gudahtt
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty reasonable to me!
danjm
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6996
This PR contains commits* fixing the following issues found during QA:
* Reviewing this commit-by-commit might be the easiest option, FYI