Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for incoming transactions #7043

Merged
merged 4 commits into from
Aug 20, 2019

Conversation

whymarrh
Copy link
Contributor

Refs #6996

This PR contains commits* fixing the following issues found during QA:

  1. CSS for transaction-list__header[...] removes CSS for History header
  2. Tx History stays populated from Mainnet while on Test Networks.
  3. [Take the incoming tx controller off] the block tracker and do a custom [timeout] for the etherscan call to avoid also pushing more traffic to infura…

* Reviewing this commit-by-commit might be the easiest option, FYI

@whymarrh whymarrh requested a review from Gudahtt as a code owner August 20, 2019 16:30
tmashuang
tmashuang previously approved these changes Aug 20, 2019
Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM all issues on my side have been addressed.

danjm
danjm previously approved these changes Aug 20, 2019
app/scripts/lib/util.js Outdated Show resolved Hide resolved
app/scripts/lib/util.js Outdated Show resolved Hide resolved
@whymarrh whymarrh dismissed stale reviews from danjm and tmashuang via 49c0c29 August 20, 2019 18:07
app/scripts/lib/util.js Outdated Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty reasonable to me!

@whymarrh whymarrh merged commit e474483 into MetaMask:develop Aug 20, 2019
@whymarrh whymarrh deleted the fix-incoming-txs branch August 20, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants