Skip to content

Commit

Permalink
JSON RPC Engine (#1236)
Browse files Browse the repository at this point in the history
* inpage => bg working

* eth_requestAccounts working

* publicConfig stream working

* clean up

* signing methods started to work

* all signing methods working

* fix warn

* added all the other wallet methods

* lots of fixes

* update prettierignore

* single iframes working

* break down bgBridge per frame

* progress

* works

* e2e passing

* clean up

* clean up

* lock deps

* use metamask-mobile-provider pkg

* fix e2e uniswap

* fix network/account change

* code review comments

* clean up

* fix

* fix ios build

* android support

* debugging

* fix stream disconnection

* uniswap working

* bump metamask-mobile-provider

* fix all the remaining issues

* Ignore warning
  • Loading branch information
Bruno Barbieri authored Jan 16, 2020
1 parent 3435b7c commit b131002
Show file tree
Hide file tree
Showing 21 changed files with 835 additions and 1,074 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ buck-out/
coverage

# app-specific
/android/app/src/main/assets/InpageBridge.js
/android/app/src/main/assets/InpageBridgeWeb3.js
/app/core/InpageBridgeWeb3.js

Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/android/app/src/main/assets/InpageBridge.js
/android/app/src/main/assets/InpageBridgeWeb3.js
/app/core/InpageBridgeWeb3.js
__snapshots__
Expand Down
5 changes: 4 additions & 1 deletion app/components/UI/AccountApproval/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,10 @@ class AccountApproval extends PureComponent {
selectedAddress,
identities
} = this.props;
const title = typeof currentPageInformation.title === 'string' ? currentPageInformation.title : getHost(url);
const title =
typeof currentPageInformation.title === 'string' && currentPageInformation.title !== ''
? currentPageInformation.title
: getHost(url);
return (
<View style={styles.root}>
<View style={styles.titleWrapper}>
Expand Down
Loading

0 comments on commit b131002

Please sign in to comment.