JSON RPC Engine #1236
JSON RPC Engine #1236
Conversation
brunobar79
requested review from
ibrahimtaveras00 and
estebanmino
and removed request for
ibrahimtaveras00
brunobar79
added
the
needs-qa
app/core/BackgroundBridge.js
Outdated
| const isInitialized = !!vault; | ||
| const { network, selectedAddress } = Engine.datamodel.flatState; | ||
| return { | ||
| ...{ isInitialized }, |
app/core/BackgroundBridge.js
Outdated
| isEnabled, | ||
| selectedAddress: isReady ? selectedAddress.toLowerCase() : null, | ||
| networkVersion: network, | ||
| chainId: `0x${parseInt(chainId, 10).toString(16)}` |
There was a problem hiding this comment.
This won't crash the app but I for rpc networks we'll be returning 0xNaN if that's ok 👍
There was a problem hiding this comment.
added a check and set it to null
|
Issue 1: On playstore/testflight when I go to uniswap and connect, pretty quickly I can see my balance on top of the ETH dropdown, however, on this branch, I don't see my balance until I reload the page seen here = http://recordit.co/7ZDqImuJ5Q Happens on both android + iOS Issue 2: Happening on both android + iOS; if I go to migrate.makerdao.com and connect, the next screen just shows an endless spinner = https://recordit.co/JAeGLqcZIf here's comparison to testflight = http://recordit.co/7ZDqImuJ5Q Issue 3: I'm having issues getting the connect modal to pop up when navigating to https://3box.io/ and tapping on choose wallet or log in. For android, I have to reload the page, then it works; while on iOS reloading the page does nothing. Seen here = http://recordit.co/Q3tLcbgzBv Issue 4: When going to peepeth, I can connect w/o any problem, however, when I try to proceed through the sign up flow, It's stopping me with the reason "Install web3 provider" seen here: Issue 5: Android only; It seems that when I navigate to mainnet.aragon.org and tap on enable account the connect modal doesn't pop up unless I reload the page and tap on enable account again Issue 6: MM Homepage > Explore Tab > Buy Crypto > Wyre > Connect with wallet > tap on MM Endless spinner for "Waiting for signature..." seen here = http://recordit.co/7varBCtOTQ Issue 7: I'm unable to connect to MM Wallet at https://trustless.ethfinex.com/ On iOS it just stays on pending with endless spinner, while on Android, nothing happens when I tap "CONNECT METAMASK"
ISSUE 8: I have to reload the page a few times in order to connect kyberswap to my MM wallet; seen here = http://recordit.co/Dg9IaeLyJr steps:
Furthermore when I do connect, I am unable to go past this view: I basically tried to "SWAP" from KNC to ETH |
|
Good news, I just built latest develop and can knock some things off this list Issue 1 happens on develop but not playstore (I'll create a different issue for this) Created = #1240 Issue 6 same, but this time I can reproduce on playstore as well compared to last week (I'll create a different issue for this) Created = #1241 Issue 7 Same Created = #1242 I've deleted the above from this PR and updated the list 👍 |
…on-rpc-engine-multi-bridge
…on-rpc-engine-multi-bridge
|
@ibrahimtaveras00 just pushed all the fixes. @estebanmino Could you please take another look ? Issue 1 - Uniswap - FIXED |
| const { approvedHosts, privacyMode, selectedAddress } = this.props; | ||
| const isEnabled = !privacyMode || approvedHosts[hostname]; | ||
| if (isEnabled) { | ||
| res.result = [selectedAddress.toLowerCase()]; |
There was a problem hiding this comment.
why toLowerCase? we have it on checksummed format
There was a problem hiding this comment.
Better safe than sorry
* inpage => bg working * eth_requestAccounts working * publicConfig stream working * clean up * signing methods started to work * all signing methods working * fix warn * added all the other wallet methods * lots of fixes * update prettierignore * single iframes working * break down bgBridge per frame * progress * works * e2e passing * clean up * clean up * lock deps * use metamask-mobile-provider pkg * fix e2e uniswap * fix network/account change * code review comments * clean up * fix * fix ios build * android support * debugging * fix stream disconnection * uniswap working * bump metamask-mobile-provider * fix all the remaining issues * Ignore warning
## **Description** * '@ethersproject/abi' - Can be cleaned from package.json since it's only used by dependencies  * @react-native-picker/picker - There is no usage for a picker anymore in the mobile app ([Introduced here](#3776))  * @rnhooks/keyboard - There is no usage for @rnhooks/keyboard ([introduced here](#1994))  * asyncstorage-down - there is no usage of asyncstorage-down ([introduced here] This one was added back, but most likely isn't needed and we need to think about replacing `react-native-level-fs` and use only one file system library * dnode - there is no usage of dnode ([introduced here](#2798)) ## **Related issues** Fixes: * obs-store - There is no usage of obs-store anymoer (introruced [here](#1236))   * react-native-flash-message - there is no usage anymore ([introduced here](#447))   * react-native-redash - there is no usage anymore (react-native-redash)   ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Replaces the whole provider implementation with https://github.com/metamask/metamask-mobile-provider which internally uses
metamask-inpage-providerso we have no more differences between the extension provider and mobileFixes #1216 ( Parity with the extension)
Fixes #1209
Fixes #1232