Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design QA #1330

Closed
1 of 2 tasks
omnat opened this issue Feb 10, 2020 · 3 comments
Closed
1 of 2 tasks

Design QA #1330

omnat opened this issue Feb 10, 2020 · 3 comments
Assignees
@cjeria @rickycodes
Milestone
Send flow & Provi...

Comments

@omnat
Copy link
Contributor

omnat commented Feb 10, 2020 •
edited by danjm
Loading

@omnat omnat added this to the Sprint Feb10 milestone Feb 10, 2020
@cjeria
Copy link

cjeria commented Feb 11, 2020 •
edited
Loading

Approve screen designs look good aside from some minor padding inconsistencies (see figma) Full details in this figma file https://www.figma.com/file/8I4cV19n2S5DsVq7Mj9Eva/Approve-Screens-v1?node-id=0%3A1

image

@omnat
Copy link
Contributor Author

omnat commented Feb 26, 2020 •
edited
Loading

@rickycodes to pick the padding updates to get it ready for release

@rickycodes rickycodes self-assigned this Feb 26, 2020
This was referenced Feb 28, 2020
Closed
Closed
@rickycodes
Copy link
Member

This work was completed in #1455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjeria cjeria

@rickycodes rickycodes

Labels
None yet
Projects
None yet
Milestone
Send flow & Provider compatibility im...
Development

Successfully merging a pull request may close this issue.

Approve Screen Design QA
Approve Screen Design QA MetaMask/metamask-mobile
3 participants
@cjeria @rickycodes @omnat