Improvement: send flow #1327
Improvement: send flow #1327
Conversation
This reverts commit dcdfbd1.
estebanmino
added
the
needs-qa
| @@ -131,6 +133,11 @@ class ContactForm extends PureComponent { | |||
| componentDidMount = () => { | |||
| const { mode } = this.state; | |||
| const { navigation } = this.props; | |||
| // Workaround https://github.com/facebook/react-native/issues/9958 | |||
There was a problem hiding this comment.
Interesting workaround. I guess we should check back on that react-native issue and remove the workaround once the underlying problem is resolved
|
All fixes look good 👍 Last issue I found is more of a question; do we want to have an ellipsis here @estebanmino @cjeria?
Same as on the send view as well
|
Yes to ellipsis. Let's try to make it as wide as possible. |
|
QA: Recent addresses only the ones from address book, not the ones not saved. This logic needs changing. @danjm |
omnat
modified the milestones:
Sprint Feb10,
Send flow & Provider compatibility improvements
|
Ellipsis fix looks good 👍
|
|
Looking good! One additional change I'd like to suggest is to remove the text "No contacts in your address book" or at least use a grey color since it looks like a tappable text link, although I'm more in favor of just removing it altogether.
|
* warning message * center * check iszero * change alias on save name * fix margins * add check * add memo * snaps * missing locales * update decodeTransferData * Revert "update decodeTransferData" This reverts commit dcdfbd1. * get tx to from data when parsing recent addresses * add editable state * new edit * locale * delete contact * edit delerte working * snaps * update contacts settings * test * rm onblur * issue 1.2 * issue 3 * issue 8 * fix 8.1 * fix check icon position * fix android * snaps * check for data * fix parsing * device isandroid * fixes * fix uppercase and long names * snaps Co-authored-by: Ibrahim Taveras <ibrahim.taveras@consensys.net>
Description
Improvements based on @cjeria doc
Checklist
Issue
Resolves #???