Approve design updates #1455
Merged
Approve design updates #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
the
needs-qa
rickycodes
force-pushed
the
approve-design-updates
branch
from
d9efb80
to
584853a
Compare
rickycodes
force-pushed
the
approve-design-updates
branch
from
584853a
to
c73ec6b
Compare
danjm-temp
reviewed
Mar 26, 2020
danjm-temp
reviewed
Mar 26, 2020
|
I reviewed and this looks good. A couple small comments, but nothing to block over. @ibrahimtaveras00 this is ready for QA |
ibrahimtaveras00
approved these changes
Mar 27, 2020
|
Where did we leave off with the font inconsistencies? I see Roboto still being used here. Our new font should be CircularXx. |
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
Changes to the gas selection button group as requested here: #1390 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design updates (from here: #1390 (comment)) also included in this PR are the margin/alignment from that same PR.
Changes to the Adjust Transaction fee Modal:
** Note: the leading white space seen here will be handled by: #1454
Changes to Reset account Modal and buttons:
Changes to Transaction Fee lockup for Confirm Transaction Edit:
** Note: there were some additional changes to be made to this area, but I've opted to do them in a separate PR since this one is already quite large... Discussed with @cjeria and this should be good enough to prevent the text from overflowing on smaller screens.