Update transaction fee selectors #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
changed the title
|
Did initial review. Looks pretty good but I might be too tired to notice any issue... or there are no issues. I am going to test it out and do a second pass in the morning and then pass it over to Ibhrahim for QA |
ibrahimtaveras00
added
the
needs-qa
rickycodes
force-pushed
the
update-transaction-fee-lockup
branch
from
57272e5
to
8e19247
Compare
rickycodes
force-pushed
the
update-transaction-fee-lockup
branch
from
8e19247
to
6222717
Compare
ibrahimtaveras00
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to the transaction fee selectors
Opening this as a Draft PR targetingapprove-design-updatesas it relies on: #1455. Once that's merged this can be re-based and updated to targetdevelop.Screenshots: