Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Security: Cannot paste password into password creation page. #1826

Closed
MicahZoltu opened this issue Sep 9, 2020 · 1 comment · Fixed by #1831
Closed

Android: Security: Cannot paste password into password creation page. #1826

MicahZoltu opened this issue Sep 9, 2020 · 1 comment · Fixed by #1831
Labels
type-bug Something isn't working

Comments

@MicahZoltu
Copy link

Describe the bug
On the Create Password activity, I am unable to long-press on the password field to paste a password. No matter how long I long-press, the paste option never appears.

This is a security issue because it means that users cannot use a password manager, they must use a human memorized password (known to be terrible for security).

To Reproduce
Steps to reproduce the behavior

  1. Copy a password from somewhere (e.g., password manager)
  2. Get to the Create Password screen.
  3. Try to paste the password.
  4. Notice that you cannot.

Expected behavior
I can paste a password into the password creation field.

Smartphone (please complete the following information):

  • Device: OnePlus
  • OS: Android
  • App Version: 1.0.2

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@MicahZoltu MicahZoltu added the type-bug Something isn't working label Sep 9, 2020
@rickycodes
Copy link
Contributor

looks like #1567 (a known issue). I will take a look at patching this shortly

rickycodes added a commit that referenced this issue Sep 14, 2020
@rickycodes
Get paste context working for password fields (onboarding), closes #1826
be8a51a
@rickycodes rickycodes mentioned this issue Sep 14, 2020
Merged
3 tasks
rickycodes added a commit that referenced this issue Sep 15, 2020
@rickycodes
Get paste context working for password fields (onboarding), closes #1826
edb896a
rickycodes added a commit that referenced this issue Sep 21, 2020
@rickycodes
Get paste context working for password fields (onboarding) (#1831)
4502fc7 
* Get paste context working for password fields (onboarding), closes #1826

* Update snapshots

* Update inputWidth

* update snapshot
rickycodes added a commit that referenced this issue Jan 31, 2022
@rickycodes
Get paste context working for password fields (onboarding) (#1831)
7955e4a 
* Get paste context working for password fields (onboarding), closes #1826

* Update snapshots

* Update inputWidth

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get paste context working for password fields (onboarding) MetaMask/metamask-mobile
2 participants
@rickycodes @MicahZoltu