Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get paste context working for password fields (onboarding) #1831

Merged
merged 5 commits into from
Sep 21, 2020
Merged

Get paste context working for password fields (onboarding) #1831

merged 5 commits into from
Sep 21, 2020

Conversation

rickycodes
Copy link
Member

Description

This ensures paste context comes back for the password fields on onboarding:

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1826

@rickycodes rickycodes requested a review from a team as a code owner September 14, 2020 20:42
@rickycodes rickycodes changed the title Get paste context working for password fields (onboarding), closes #1826 Get paste context working for password fields (onboarding) Sep 14, 2020
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 14, 2020
EtDu
EtDu reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the desired effect fail if we leave the width as 100% in styles without having it inside the state being modified on component mount?

@rickycodes
Copy link
Member Author

sadly yes. you can read more about the issue here: facebook/react-native#9958 (comment)

fb has multiple "stale" issues outlining the problem. you can see another fix we applied for the same thing here: #1548

@rickycodes
Copy link
Member Author

rickycodes commented Sep 15, 2020 •
edited
Loading

I've seen others solve it by mounting the text component with editable={false} and then changing it to true to get the desired result. maybe that's a cleaner solution and we should try that instead?

EtDu
EtDu approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say as long as there are no perf drawbacks from using setTimeout then no problem

ibrahimtaveras00
ibrahimtaveras00 approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good now, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 21, 2020
@rickycodes rickycodes merged commit 4502fc7 into develop Sep 21, 2020
@rickycodes rickycodes deleted the issue-1826 branch September 21, 2020 21:48
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Get paste context working for password fields (onboarding) (#1831)
7955e4a 
* Get paste context working for password fields (onboarding), closes #1826

* Update snapshots

* Update inputWidth

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtDu EtDu EtDu approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android: Security: Cannot paste password into password creation page.
3 participants
@rickycodes @EtDu @ibrahimtaveras00