Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account names are changed when syncing and logging out #2002

Closed
ibrahimtaveras00 opened this issue Nov 17, 2020 · 1 comment · Fixed by #2469
Closed

Account names are changed when syncing and logging out #2002

ibrahimtaveras00 opened this issue Nov 17, 2020 · 1 comment · Fixed by #2469
Assignees
@sethkfman
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) support type-bug Something isn't working
Milestone
Tooling Sprint

Comments

@ibrahimtaveras00
Copy link
Contributor

Describe the bug

@cjeria noticed that:
After syncing with extension and then logging out account names are reverted back to the default

To Reproduce
Steps to reproduce the behavior

  1. Already have a wallet (doesn't matter which wallet) on your MM app
  2. Logout
  3. Sync with extension on a wallet that has unique account names
  4. after syncing take note of your account names in the app (they should match extension)
  5. logout and kill app
  6. relaunch app and login, notice how the names are reverted to the typical Account 1 format

Expected behavior

Unique account names should stick after logging out and logging back in

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@ibrahimtaveras00 ibrahimtaveras00 added the type-bug Something isn't working label Nov 17, 2020
@ibrahimtaveras00
Copy link
Contributor Author

Also I just noticed this, on version 1.0.7 we are now allowing the ability to change password. Upon changing password, the account names are reset back to default names (Account 1, etc)

@omnat omnat added the support label Apr 2, 2021
sethkfman added a commit that referenced this issue Apr 2, 2021
@sethkfman
added functionality to persists old account names when resetting pass…
fad06e3 
…word #2002
@sethkfman sethkfman mentioned this issue Apr 2, 2021
Merged
3 tasks
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 2, 2021
@omnat omnat added this to the Tooling Sprint milestone Apr 8, 2021
sethkfman added a commit that referenced this issue Apr 15, 2021
@sethkfman
Bug/persists old account names (#2469)
4f69e25 
* added functionality to persists old account names when resetting password #2002

* added logic to check for old account/identities and persist their balances and names

* added check to see if it is not an existing user

* added check to see if it is a existing user

* add sync utility code and test to reduce common code

* remove logs
rickycodes pushed a commit that referenced this issue Jan 31, 2022
@sethkfman
Bug/persists old account names (#2469)
311c3aa 
* added functionality to persists old account names when resetting password #2002

* added logic to check for old account/identities and persist their balances and names

* added check to see if it is not an existing user

* added check to see if it is a existing user

* add sync utility code and test to reduce common code

* remove logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sethkfman sethkfman

Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) support type-bug Something isn't working
Projects
None yet
Milestone
Tooling Sprint
Development

Successfully merging a pull request may close this issue.

Bug/persists old account names MetaMask/metamask-mobile
3 participants
@sethkfman @ibrahimtaveras00 @omnat