Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/persists old account names #2469

Merged
merged 12 commits into from
Apr 15, 2021
Merged

Bug/persists old account names #2469

merged 12 commits into from
Apr 15, 2021

Conversation

sethkfman
Copy link
Contributor

…word #2002

Description

Bug fix to persists account names when resetting password.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2002

@sethkfman sethkfman requested a review from a team April 2, 2021 16:29
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 2, 2021
@sethkfman sethkfman changed the title added functionality to persists old account names when resetting pass… Bug/persists old account names Apr 5, 2021
rickycodes
rickycodes approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 8, 2021
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 8, 2021
andrepimenta
andrepimenta approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrepimenta andrepimenta removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2021
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 14, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good on both OS's for all scenarios

  • synced wallet & changing password
  • imported wallet > change account names & changing password
  • new wallet > change account names & change password

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 14, 2021
@sethkfman sethkfman merged commit 4f69e25 into develop Apr 15, 2021
@sethkfman sethkfman deleted the bug/#2002_accountnames branch April 15, 2021 20:12
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@sethkfman
Bug/persists old account names (#2469)
311c3aa 
* added functionality to persists old account names when resetting password #2002

* added logic to check for old account/identities and persist their balances and names

* added check to see if it is not an existing user

* added check to see if it is a existing user

* add sync utility code and test to reduce common code

* remove logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account names are changed when syncing and logging out
4 participants
@sethkfman @rickycodes @andrepimenta @ibrahimtaveras00