Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the contract receiving token allowances on the allowance screen #2723

Closed
danfinlay opened this issue May 25, 2021 · 2 comments · Fixed by #3692
Closed

Show the contract receiving token allowances on the allowance screen #2723

danfinlay opened this issue May 25, 2021 · 2 comments · Fixed by #3692
Assignees
Labels
Code Impact - Medium Average task code change that can relatively safely being applied to the codebase needs-design Feature that requires UI/UX design

Comments

@danfinlay
Copy link
Contributor

danfinlay commented May 25, 2021

Description
Apply this to the Approve DAPP Browser flow for smart contract TXs.

Acceptance Criteria

References

image

Address naming fallback logic https://www.notion.so/address-display-fallback-logic-520b84be34b84952b5cb9fd0b508ce23

Design file ( @yanrong-chen will add) for where to show the contract address, and address book prompt.

@sethkfman sethkfman added the needs-design Feature that requires UI/UX design label Jan 25, 2022
@sethkfman sethkfman assigned sethkfman and yanrong-chen and unassigned sethkfman Jan 25, 2022
@sethkfman
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @blackdevelopa @cortisiko

@sethkfman sethkfman added the Code Impact - Medium Average task code change that can relatively safely being applied to the codebase label Jan 26, 2022
@mobularay mobularay added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 8, 2022
@sethkfman
Copy link
Contributor

@cortisiko When testing this make sure the custom allowance option is behaving as expected.

For reference: #3863

@cortisiko cortisiko removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Impact - Medium Average task code change that can relatively safely being applied to the codebase needs-design Feature that requires UI/UX design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants