Show the contract receiving token allowances on the allowance screen

[blackdevelopa]

Description

Contract address naming

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

Issue

Resolves #2723

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sethkfman]

Minor updates required to use locales

[cortisiko]

Issue 1
I get this warning: ERROR Warning: Failed prop type: Invalid prop protectWalletModalVisible of type function supplied to ApproveTransactionReview, expected boolean.

When I attempted to approve a token

to reproduce:
go here while on a test net (because you do not want to use real funds)
connect your wallet
scroll down on the page and tap on create token
after your txn was confirmed tap on “approve token”
notice the confirmation modal appears with the error

Issue 2
after saving the contract address to my contacts I get: Cannot update during an existing state transition (such as within render). Render methods should be a pure function of props and state

see here

to reproduce:
go here while on a test net (because you do not want to use real funds)
connect your wallet
scroll down on the page and tap on create token
after your txn was confirmed tap on “approve token”
notice the confirmation modal appears. Now tap on “Add nickname”
input a nick name then hit save

notice the error appears

Issue 3
On the edit nick name view I am unable to share my address. Tapping on the share icon does nothing. On the other hand tapping on the address does not copy it to my clipboard. I need to carefully tap on the copy icon in order to copy. Even when i do copy my address i see a toast message “shell was pasted from your clipboard”. Maybe it should be “address was copied to your clipboard” ?

see here

Issue 4
the contract i added to my contacts should not appear in recents

to reproduce:
go here while on a test net (because you do not want to use real funds)
connect your wallet
scroll down on the page and tap on create token
after your txn was confirmed tap on “approve token”
notice the confirmation modal appears. Now tap on “Add nickname”
input a nick name then hit save
return to the wallet view then go through the send flow
notice the contract address appears

[blackdevelopa]

Issue 1 I get this warning: ERROR Warning: Failed prop type: Invalid prop protectWalletModalVisible of type function supplied to ApproveTransactionReview, expected boolean.

When I attempted to approve a token

to reproduce: go here while on a test net (because you do not want to use real funds) connect your wallet scroll down on the page and tap on create token after your txn was confirmed tap on “approve token” notice the confirmation modal appears with the error

Thank you for catching this, QA issue 1 is now fixed.

Issue 2 after saving the contract address to my contacts I get: Cannot update during an existing state transition (such as within render). Render methods should be a pure function of props and state

see here

to reproduce: go here while on a test net (because you do not want to use real funds) connect your wallet scroll down on the page and tap on create token after your txn was confirmed tap on “approve token” notice the confirmation modal appears. Now tap on “Add nickname” input a nick name then hit save

notice the error appears

Thank you for catching this, QA issue 2 is now fixed.

Issue 3 On the edit nick name view I am unable to share my address. Tapping on the share icon does nothing. On the other hand tapping on the address does not copy it to my clipboard. I need to carefully tap on the copy icon in order to copy. Even when i do copy my address i see a toast message “shell was pasted from your clipboard”. Maybe it should be “address was copied to your clipboard” ?

see here

Thank you for catching this, QA issue 3 is now fixed. We've got approval from Design on the share icon

Issue 4 the contract i added to my contacts should not appear in recents to reproduce: go here while on a test net (because you do not want to use real funds) connect your wallet scroll down on the page and tap on create token after your txn was confirmed tap on “approve token” notice the confirmation modal appears. Now tap on “Add nickname” input a nick name then hit save return to the wallet view then go through the send flow notice the contract address appears

Thank you for catching this, QA issue 4 is now fixed

[cortisiko]

🌮 🌮 🌮