Use Linking to support URLs using default browser #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
issue-1295
branch
from
e9313e5 to
7f8bbd6
Compare
rickycodes
changed the title
estebanmino
suggested changes
Jan 28, 2020
rickycodes
force-pushed
the
issue-1295
branch
4 times, most recently
from
b7c1100 to
48097b6
Compare
|
I added the platform check so the two support links only promp user for default browser on Android. |
rickycodes
commented
Jan 29, 2020
brunobar79
added
the
needs-qa
rickycodes
force-pushed
the
issue-1295
branch
5 times, most recently
from
00b1182 to
75bf32e
Compare
estebanmino
approved these changes
Feb 4, 2020
This fix is not ideal. Unfortunately, there seems to be an incompatibility between the webview component and the vendor (zendesks') reCAPTCHA (by Google Inc.). One potential way to fix this would be to alter the display CSS and/or JavaScript on the vendor site to change the positioning of the captcha overlay? However, once we start on this road we'll be doing the same thing for all sorts of incompatibilities all over the web. That said, maybe it's worth looking into fixing this one somehow… Google's reCAPTCHA is everywhere.
rickycodes
force-pushed
the
issue-1295
branch
from
75bf32e to
0ce7c7d
Compare
3 tasks
ibrahimtaveras00
approved these changes
Feb 4, 2020
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
This fix is not ideal. Unfortunately, there seems to be an incompatibility between the webview component and the vendor (zendesks') reCAPTCHA (by Google Inc.). One potential way to fix this would be to alter the display CSS and/or JavaScript on the vendor site to change the positioning of the captcha overlay? However, once we start on this road we'll be doing the same thing for all sorts of incompatibilities all over the web. That said, maybe it's worth looking into fixing this one somehow… Google's reCAPTCHA is everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #1295
context: when the user goes to "Send Feedback" and they're presented with "GENERAL" and "BUG REPORT" the user will be prompted to open the link in their default browser. this is because the zendesk form does not submit in metamask mobile. this should only affect functionality in android.
Alternatively we could check what platform is being used and only adjust this functionality on Android?this PR does this now
resolves: #1295