Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source commit for react-native-webview in package.json #1427

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Mar 17, 2020

Updates package.json to point to the latest commit on our react-native-webview fork.

This will include the changes added with MetaMask/react-native-webview#2

fixes #1242

@omnat
Copy link
Contributor

omnat commented Mar 19, 2020

@danjm what's the next step on this one? cc @ibrahimtaveras00

@danjm danjm force-pushed the react-native-webview-version-bump branch from 810062e to b6b5fb2 Compare March 25, 2020 16:05
@danjm danjm force-pushed the react-native-webview-version-bump branch 2 times, most recently from d754598 to 35a32ee Compare April 7, 2020 17:03
@danjm danjm added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 7, 2020
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good, QA Passed 👍

@danjm danjm force-pushed the react-native-webview-version-bump branch from 35a32ee to 85a0330 Compare April 15, 2020 02:10
@danjm danjm merged commit 024bea1 into develop Apr 15, 2020
@danjm danjm deleted the react-native-webview-version-bump branch April 15, 2020 04:12
nanaluz added a commit to nanaluz/metamask-mobile that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: JSON RPC error on opensea item
4 participants