This repository has been archived by the owner on May 12, 2022. It is now read-only.
Prevent js injection for non-200 response status codes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shouldInterceptRequest of webviewmanager
…s and when containing some html
danjm
force-pushed
the
prevent-js-injection-of-error-response
branch
from
96571da
to
28eff2e
Compare
rekmarks
changed the title
rekmarks
suggested changes
Mar 19, 2020
android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
Outdated
Show resolved
Hide resolved
…CWebViewManager.java
rekmarks
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic for intercepting requests can result in an attempt to inject our js within text/html that comes with responses that have error codes. Also in cases where the body of the response is not actually text/html (perhaps this is something we should not be concerned with, but we also don't want to be enforcers of http standards). This can cause responses to requests from pages within our webview to be incorrectly modified, or to error without clear reason.
This PR ensures that we only intercept and inject JS into requests that are successful, have the content type: text/html header and actually contain some html in the body of the response.