Add /constants #1728
Closed
Add /constants #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
feature/add-constants
branch
4 times, most recently
from
e0cfc8d to
5c6135d
Compare
rickycodes
added
the
needs-dev-review
rickycodes
force-pushed
the
feature/add-constants
branch
6 times, most recently
from
44b7c1b to
fe57bf3
Compare
rickycodes
force-pushed
the
feature/add-constants
branch
4 times, most recently
from
bcfb98e to
6db50dd
Compare
rickycodes
removed
the
needs-dev-review
rickycodes
force-pushed
the
feature/add-constants
branch
from
ce2c2c1 to
f7da43a
Compare
|
grouping this with #1797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was based on some feedback from @estebanmino and it's true,
AppConstantsshould be treated separately.for the storage keys we were repeating ourselves an awful lot, so I thought it might be good to have some constants for that as well. surprisingly, there's only 15 keys related to storage.