Bugfixes/post v1 aug 2020 #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
the
needs-qa
This was referenced Aug 26, 2020
Closed
rickycodes
force-pushed
the
bugfix/post-v1-aug-2020
branch
from
9218d38
to
edb09c6
Compare
rickycodes
force-pushed
the
bugfix/post-v1-aug-2020
branch
from
edb09c6
to
01fdc41
Compare
rickycodes
added
the
needs-dev-review
estebanmino
reviewed
Aug 26, 2020
estebanmino
reviewed
Aug 26, 2020
estebanmino
reviewed
Aug 26, 2020
3 tasks
rickycodes
force-pushed
the
bugfix/post-v1-aug-2020
branch
from
d28286c
to
c2efeed
Compare
estebanmino
approved these changes
Sep 1, 2020
rickycodes
force-pushed
the
bugfix/post-v1-aug-2020
branch
from
72c5b05
to
45160b0
Compare
ibrahimtaveras00
added
QA in Progress
ibrahimtaveras00
suggested changes
Sep 8, 2020
ibrahimtaveras00
added
QA'd - Issues Found
rickycodes
force-pushed
the
bugfix/post-v1-aug-2020
branch
from
45160b0
to
1185478
Compare
|
@ibrahimtaveras00 this one should be good-to-go again! |
rickycodes
added
needs-qa
rickycodes
force-pushed
the
bugfix/post-v1-aug-2020
branch
from
2c03662
to
6fc82f4
Compare
ibrahimtaveras00
approved these changes
Sep 11, 2020
ibrahimtaveras00
added
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Fix typo * Add resetAutocompleteInputValue() * Remove console.log() * Use translations for steps * Use title * Add some missing translation strings * Add missing es translations * Add /constants * Add constants for storage keys * constants++ * Add constants for true, agreed, denied, debug * Add const for EXPLORED * Add constants for ENCRYPTION_LIB and ORIGINAL * Display correct balance from state * Document props * Remove accounts prop * Use ownProps to get updatedBalanceFromStore * Add missing currencies and add `base` programatically * Update CHANGELOG.md * Update snapshot * We don't actually need this * Add constants for onboarding steps * Update captureMessage to use storage constant * Update CHANGELOG * Add ANIMATION_TIMING constant * Delay reset * Uppercase fiat currency acronyms * Simplify via destructuring * Update AccountInfoCard * Use scaling * Remove space * Add this.steps back in * Scale font down * Uppercase remaining texts * one final upper * Update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a grouping of PRs to clean things up a bit and make review/QA a bit easier on everyone.
this PR includes the following work:
#1781 (this has been approved, this is just a code change, no functionality changed)
#1759 (this is a bugfix and needs QA)
#1728 (just some code cleanup, no functionality changed)
#1787 (add missing currencies, in particular SAI and INR needs QA)
#1800 (minor improvement to search input, needs QA)