Add missing currency conversions #1787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
needs-dev-review
rickycodes
changed the title
rickycodes
force-pushed
the
bugfix/add-missing-currencies
branch
from
19dce21 to
7b7010c
Compare
rickycodes
force-pushed
the
bugfix/add-missing-currencies
branch
from
7b7010c to
b95ede9
Compare
This was referenced Aug 23, 2020
|
Likely going to close this in favour of: #1797 |
|
grouping this with #1787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing currency conversions re: #1777. I also noticed that
basewas the same for all of these, so I am just adding that programmatically now. Once this is merged we'll have the missing conversions:Option in Settings:
Displayed as fiat:
Checklist
Issue
Resolves #1777