Display correct balance from state when creating an account that already holds funds #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
needs-dev-review
rickycodes
commented
Aug 10, 2020
| const { accounts } = AccountTrackerController; | ||
| const selectedAccount = accounts[selectedAddress]; | ||
| const selectedAccountHasBalance = | ||
| selectedAccount && Object.prototype.hasOwnProperty.call(selectedAccount, BALANCE_KEY); |
There was a problem hiding this comment.
normally i would just use obj.hasOwnProperty() directly here, but I guess we don't allow that with this rule: https://eslint.org/docs/rules/no-prototype-builtins
rickycodes
changed the title
EtDu
reviewed
Aug 13, 2020
|
@EtDu I just tried to move this logic into |
rickycodes
force-pushed
the
bugfix/display-correct-balance-from-state
branch
from
5c23554
to
4cb235f
Compare
|
grouping this in with #1797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
re: https://trello.com/c/NytEfYLU/191-after-importing-a-wallet-with-seedphrase-new-account-shows-0-balance-until-another-account-is-created
Previously when adding a new account that already has funds we'd see it displayed with zero in the drawer:
(you can see the fiat balance is correct in the background)
Now we check state to see if we have the amount and display it if there's a balance for the matching account:
Checklist
Issue
Resolves #???