Feature/custom nonce #2371
Merged
Feature/custom nonce #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
reviewed
Mar 11, 2021
rickycodes
force-pushed
the
feature/custom-nonce
branch
from
d255370
to
26f1079
Compare
rickycodes
added
needs-dev-review
|
For the warning copy, instead of repeating what is already mentioned in the default copy below the warning, I'm now thinking we should mention what could happen if they continue with the higher than suggested nonce. How about something like this instead? cc @rickycodes @omnat @jakehaugen |
rickycodes
force-pushed
the
feature/custom-nonce
branch
from
4f5f168
to
8ac0c4d
Compare
Gudahtt
reviewed
Mar 23, 2021
rickycodes
force-pushed
the
feature/custom-nonce
branch
4 times, most recently
from
18b4c99
to
76d4466
Compare
estebanmino
reviewed
Mar 29, 2021
estebanmino
reviewed
Mar 29, 2021
omnat
added
the
design-review
rickycodes
force-pushed
the
feature/custom-nonce
branch
from
5528e7b
to
716fed9
Compare
rickycodes
added
needs-qa
|
I've gone ahead and removed the design qa label since I've gone over this with Christian and he's okay'd it all. re: #2371 (review) I've addressed all QA feedback except for issue 3 as discussed. this is ready for qa again. |
estebanmino
reviewed
Apr 8, 2021
estebanmino
reviewed
Apr 8, 2021
app/components/UI/TransactionReview/TransactionReviewInformation/index.js
Outdated
Show resolved
Hide resolved
estebanmino
reviewed
Apr 8, 2021
| export const getNetworkNonce = async ({ from }) => { | ||
| const { TransactionController } = Engine.context; | ||
| const networkNonce = await util.query(TransactionController.ethQuery, 'getTransactionCount', [from, 'pending']); | ||
| return parseInt(networkNonce, 16); |
…on/index.js Co-authored-by: Esteban Miño <efmino@uc.cl>
…obile into feature/custom-nonce * 'feature/custom-nonce' of github.com:MetaMask/metamask-mobile: Update app/components/UI/TransactionReview/TransactionReviewInformation/index.js
estebanmino
removed
the
needs-dev-review
ibrahimtaveras00
added
next release
QA in Progress
ibrahimtaveras00
approved these changes
Apr 14, 2021
ibrahimtaveras00
added
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Add custom nonce switch
* update snapshot
* Use props
* Get edit nonce button in place
* Add edit nonce modal
* Add translation strings
* Add CustomNonceModal component
* Add proposedNonce
* undo
* Update styles and translation strings
* Use a hook
* Save nonce to state
* Add IncrementDecrementSvg component
* Add comment for newly added prop
* Fix width @ 80
* Add component tests
* Add tests
* Display warning
* Update tests
* Add getProposedNonce
* Merge some utils and add tests
* Add constants
* Use object property shorthand
* Fix displayWarning to account for String
* Add ModalDragger
* Add save and cancel
* Use the TransactionController from "@metamask/controllers"
* Only use custom nonce if showCustomNonce
* Update snapshot
* Start using Base/Text
* Add colors to Base/Text component
* Account for NaN values
* Use Base/Text
* Move increment decrement buttons down
* Update tests
* Add showSoftInputOnFocus={false}
* Update tests
* Add icon
* Use link
* Update tests
* prep for QA
* Update warning text
* Use 6.2.0 controllers
* Update translation strings
* update snapshot
* Remove TODO
* Use EvilIcons
* Update snapshot
* Beef up tests for toLowerCaseCompare
* Remove comment
* update snapshot
* Get nonce from network
* Update snapshot
* fix lint nits
* fix copy
* Update snapshot
* Move edit nonce functionality into TransactionReviewFeeCard
* Add custom nonce to dapp send
* Use redux actions
* Continue using actions
* Set custom nonce on confirm
* Update snapshot
* Move nonce and proposedNonce off transaction object
* Bump controllers
* Only getNetworkNonce if proposedNonce is not set
* fix props
* delete tgz
* Add getNetworkNonce to networks utility
* document props
* Update snapshots
* Update app/components/UI/TransactionReview/TransactionReviewInformation/index.js
Co-authored-by: Esteban Miño <efmino@uc.cl>
* use nonce directly instead of passing it in render
Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this as a Draft as it relies on MetaMask/core#381
This adds a new setting under Advanced that lets you edit the nonce rather than getting it from the network:
Displays suggested nonce when you do a new send:
which can then be edited:
Checklist
Issue
Resolves #2126