Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics v2 (priority 1) #2456

Merged
merged 17 commits into from
Apr 7, 2021
Merged

Analytics v2 (priority 1) #2456

merged 17 commits into from
Apr 7, 2021

Conversation

andrepimenta
Copy link
Member

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@andrepimenta andrepimenta requested a review from a team as a code owner March 30, 2021 17:25
@andrepimenta andrepimenta marked this pull request as draft March 30, 2021 17:26
@omnat omnat added next release No QA Needed Apply this label when your PR does not need any QA effort. labels Apr 5, 2021
estebanmino
estebanmino reviewed Apr 7, 2021
View reviewed changes
app/util/analyticsV2.js Outdated Show resolved Hide resolved
@andrepimenta andrepimenta marked this pull request as ready for review April 7, 2021 21:02
@danigorbaciov
Copy link

god job

@andrepimenta
Adding more fallbacks and updating unit tests
b706465
@andrepimenta
Merge branch 'develop' into feature/analytics-v2-p1
2387942 
# Conflicts:
#	app/components/UI/CustomGas/index.js
#	app/components/UI/TransactionEditor/index.js
@andrepimenta andrepimenta merged commit c621de7 into develop Apr 7, 2021
@andrepimenta andrepimenta deleted the feature/analytics-v2-p1 branch April 7, 2021 22:03
rickycodes added a commit that referenced this pull request Apr 8, 2021
@rickycodes
Merge branch 'develop' into feature/custom-nonce
40b99f6 
* develop:
  v2.1.0 (#2481)
  Analytics v2 (priority 1) (#2456)
  Fix/gas estimations (#2408)
rickycodes added a commit that referenced this pull request Apr 8, 2021
@rickycodes
Merge branch 'develop' into feature/confusables
6f99419 
* develop:
  v2.1.0 (#2481)
  Analytics v2 (priority 1) (#2456)
  Fix/gas estimations (#2408)
  remove controllers tgz (#2479)
  Improvement/assets by chainid (#2441)
  Improvement/chain ticker (#2442)
  Remove instapay (#2372)
  Fix iOS build (#2467)
  Migrate from AsyncStorage to FileStorage (#2084)
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Analytics v2 (priority 1) (#2456)
2331f3c 
* Init analytics

* Insert category

* Add anonymous functionality

* Add interactionmanager

* Move analytics to parent on dapp transactions

* Add missing gas analytics

* Add all properties to anonymous params

* Analytics to networks

* Add metrics opt in item

* Change anonymous params

* Change name from log to trackEvent

* Accounting for undefineds

* Adding more fallbacks and updating unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danigorbaciov danigorbaciov danigorbaciov approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
next release No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrepimenta @danigorbaciov @estebanmino @ibrahimtaveras00 @omnat