Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/assets by chainid #2441

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Improvement/assets by chainid #2441

merged 7 commits into from
Apr 7, 2021

Conversation

estebanmino
Copy link
Contributor

Description

Deprecation of networkType in favor of chainId to store assets.

A migration was added to migrate existing assets

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2391

@estebanmino estebanmino requested a review from a team as a code owner March 29, 2021 13:34
@estebanmino estebanmino mentioned this pull request Mar 29, 2021
Merged
@estebanmino estebanmino added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. next release labels Mar 29, 2021
@estebanmino estebanmino mentioned this pull request Mar 29, 2021
Closed
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 5, 2021
ibrahimtaveras00
ibrahimtaveras00 suggested changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the migration didn't get picked up

For example, OMI should not be here under BNB as it belongs to GoChain network

image

Steps:

  • build v2.0.1 on both OS’s
  • yarn clean && yarn watch:clean
  • yarn start:ios and yarn start:android
  • import your wallet, add networks + tokens
  • stay on either network (before putting app in background stay on BNB or GoChain)
  • put app in background
  • switch to improvement/assets-by-chainid
  • yarn clean && yarn watch:clean
  • yarn start:ios and yarn start:android
  • login, notice how it’s still the same

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Apr 6, 2021
@ibrahimtaveras00
Copy link
Contributor

This does work when you create a fresh wallet and add the networks and custom tokens

seen here = http://recordit.co/f7zWGgcDIh

ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Apr 6, 2021
andrepimenta
andrepimenta approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estebanmino estebanmino merged commit 94c705c into develop Apr 7, 2021
@estebanmino estebanmino deleted the improvement/assets-by-chainid branch April 7, 2021 14:53
@estebanmino estebanmino mentioned this pull request Apr 7, 2021
Merged
3 tasks
rickycodes added a commit that referenced this pull request Apr 8, 2021
@rickycodes
Merge branch 'develop' into feature/confusables
6f99419 
* develop:
  v2.1.0 (#2481)
  Analytics v2 (priority 1) (#2456)
  Fix/gas estimations (#2408)
  remove controllers tgz (#2479)
  Improvement/assets by chainid (#2441)
  Improvement/chain ticker (#2442)
  Remove instapay (#2372)
  Fix iOS build (#2467)
  Migrate from AsyncStorage to FileStorage (#2084)
@mobularay mobularay mentioned this pull request Jul 19, 2021
Closed
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Improvement/assets by chainid (#2441)
dbc83b0 
* migrations

* add custom rpc assets

* addpackage

* bumpcontroller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View my assets displayed accurately (specific to the network)
3 participants
@estebanmino @ibrahimtaveras00 @andrepimenta