Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: decode transfer data bug #3126

Merged
merged 3 commits into from
Sep 22, 2021
Merged

fixed: decode transfer data bug #3126

merged 3 commits into from
Sep 22, 2021

Conversation

ubearline
Copy link
Contributor

amount index is 74 to 138

stringObject.substr(start,length)

The correct way to use it should be like this

const encodedAmount = data.substr(74, 64);

@ubearline ubearline requested a review from a team as a code owner September 14, 2021 09:29
@ubearline
Copy link
Contributor Author

maybe the same issue #3050

sethkfman
sethkfman approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman
Copy link
Contributor

Thank you for the contribution.

@sethkfman sethkfman merged commit 8550acd into MetaMask:develop Sep 22, 2021
@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 22, 2021
@ubearline ubearline deleted the fix_decode_bug branch September 23, 2021 02:13
rickycodes added a commit that referenced this pull request Sep 30, 2021
@rickycodes
Revert "fixed: decode transfer data bug (#3126)"
c1a1261 
This reverts commit 8550acd.
@rickycodes rickycodes mentioned this pull request Sep 30, 2021
Merged
rickycodes added a commit that referenced this pull request Sep 30, 2021
@rickycodes
Revert "fixed: decode transfer data bug (#3126)" (#3236)
ecd66dc 
This reverts commit 8550acd.
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@ubearline @sethkfman
fixed: decode transfer data bug (#3126)
11e03bd 
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Revert "fixed: decode transfer data bug (#3126)" (#3236)
fb02e5c 
This reverts commit 8550acd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubearline @sethkfman