Parse transaction data correctly #3050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
needs-qa
cortisiko
added
QA in Progress
added 2 commits
September 15, 2021 18:48
…into fix/parse-tx-data-correctly
…Mask/metamask-mobile into fix/parse-tx-data-correctly
|
Moving this solution to 3129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the way we parse transaction data.
@ibrahimtaveras00
How to test:
Test token transfers (ERC20 and ERC721) requested from a Dapp. Would be nice to check the etherscan parameters against the same transaction made by the extension, especially:
Before:
After:
Checklist
Issue
Resolves #2744
Resolves #3051