-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse transaction data correctly #3129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrepimenta the transaction data still appears scrambled. See here
To reproduce:
Connect to this dappp: https://sorbet-finance-git-fix-metamask-mobile-bug-2-gelato.vercel.app/ (I used ropsten as my network)
Attempt to transfer some eth
Notice the transaction data appears wonky.
@cortisiko Can you check against extension, if it's the same then it should be correct: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🌮 🌮 🌮 🌮
Co-authored-by: andrepimenta <andrepimenta7@gmail.com>
Description
This PR fixes the way we parse transaction data.
@ibrahimtaveras00
How to test:
Test token transfers (ERC20 and ERC721) requested from a Dapp. Would be nice to check the etherscan parameters against the same transaction made by the extension, especially:
Before:
After:
Checklist
Issue
Resolves #2744
Resolves #3051