Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Tx details speed up and cancel actions #3979

Merged
merged 4 commits into from
Apr 4, 2022
Merged

[FIX] Tx details speed up and cancel actions #3979

merged 4 commits into from
Apr 4, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Mar 30, 2022 •
edited
Loading

Description

The speed up and cancel action in the TransactionDetails were not performing any action, this PR closes the TransactionDetails component and prompts the modal to speed up or cancel the transaction.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3976

@gantunesr gantunesr requested a review from a team as a code owner March 30, 2022 02:44
@gantunesr gantunesr changed the title [FIX] Tx details speed up and cancel actiones [FIX] Tx details speed up and cancel actions Mar 30, 2022
@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 30, 2022
Cal-L
Cal-L approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 30, 2022
@cortisiko cortisiko added Mobile QA board QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 3, 2022
cortisiko
cortisiko approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@gantunesr gantunesr merged commit 24869a1 into main Apr 4, 2022
@gantunesr gantunesr deleted the fix/tx-action-details-modal branch April 4, 2022 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to cancel or speed up from Transaction detail
3 participants
@gantunesr @Cal-L @cortisiko