Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cherry-pick (#8725) #8767

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix: cherry-pick (#8725) #8767

merged 2 commits into from
Feb 29, 2024

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Feb 28, 2024 •
edited
Loading

Cherry-pick fix for #8725 on version 7.17.0.

@blackdevelopa blackdevelopa requested a review from a team as a code owner February 28, 2024 10:50
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f88855d1-c3c5-40a9-8918-92a519dc114f
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@blackdevelopa blackdevelopa changed the title fix: cherrypick (#8725) fix: cherry-pick (#8725) Feb 28, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 28, 2024
@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb5148c5-a2fd-4388-8e02-4f51ae19411d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sethkfman sethkfman added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Feb 28, 2024
sethkfman
sethkfman approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit e0b5f71 into release/7.17.0 Feb 29, 2024
27 checks passed
@sethkfman sethkfman deleted the cherrypick-8725 branch February 29, 2024 00:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 29, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.17.0 on PR, as PR was cherry-picked in branch 7.17.0.

@seaona
Copy link
Contributor

seaona commented Feb 29, 2024

🟢 This PR is QA passed. There's a small UI issue but it's not a blocker for the release
#8782

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.17.0 Issue or pull request that will be included in release 7.17.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blackdevelopa @metamaskbot @seaona @sethkfman @jpuri