7.17.0 #8612

github-actions · 2024-02-16T19:41:10Z

This is the release candidate for version 7.17.0.

## **Description** This PR merges 7.16.0 into 7.17.0 the major conflict that occurred was in the migration files. The PR creates a migration file 29 that applies the changes which were in `main`. - Migration 28 address bug #8578 - Migration 29 represent the work done here #7999 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-02-16T22:54:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

brianacnguyen · 2024-02-22T22:45:38Z

Changes from design system team for 7.17 should be working as expected

gantunesr · 2024-02-23T12:55:20Z

Changes for the Accounts team are validated,

chore: add logs to identify root cause of issue reported in #1507 #8414

## **Description** This PR cherry-picks #8615 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46e749cb-c149-4ced-bc40-a9e5e1bed3c8 Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88873d22-4fea-45c3-83f3-eb034aa3ee32 ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

katkopel · 2024-02-25T00:35:36Z

Testing iOS v.7.17.0 (1266)

Onboarding: custom ETH mainnet
✅ Custom mainnet Scenario 1 (Verifying Custom Mainnet Screen Appears):
✅ Custom mainnet Scenario 2 (Entering an Invalid Mainnet RPC URL):
✅ Custom mainnet Scenario 3 (Entering a valid mainnet RPC URL):
✅ Custom mainnet Scenario 4 (Editing a custom mainnet URL on the settings and privacy view):
✅ Custom mainnet Scenario 5 (Deleting a custom mainnet URL on the settings and privacy view):
❗Deleting RPC URL before clicking the Delete button causes the app to crash
https://recordit.co/mNdFpgDM2f

QR Scanner Regression
✅ From the in-app camera I should be able to scan a valid QR code containing an address:
https://recordit.co/cwoXdVikkn

✅ I should be able to use the QR scanner on the send flow to scan an address:
https://recordit.co/5jRKI9lkrg

✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message:
https://recordit.co/5vw3KTRU5d

✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message:
https://recordit.co/1druZr3DWd

❌ When I scan an invalid address QR code using the in app camera I should see the appropriate warning message: FAILED - no warning message:
https://recordit.co/KyXIbe8wq5

✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message:
https://recordit.co/M8ORKyqraR

✅ A user can scan a private key QR code using the in-app camera to import an account:
https://recordit.co/yS1KtmO0AA

✅ User scans MMM Receive QR code on different network:
https://recordit.co/C32eOjGTxC

Setting: General view
✅ Scenario: Changing the device language from English to Russian:
❗ The “What’s New” pop-up has some English text. English text appears in Settings after redirect.
https://recordit.co/labOJN8ae5

✅ Scenario: Changing the app language from English to Filipino:
❗ Automatically check for security updates pop-up appears twice
https://recordit.co/U26g95VYD6

Browser Regression
✅ Scenario: Searching an invalid url and prompts the user with an error message:
https://recordit.co/EI3w4ICAGW

✅ Scenario: Navigation with browser controls:
https://recordit.co/B9E9Yc2DqR

✅ Scenario: ENS website loads correctly:
https://recordit.co/8cJyWemE61

✅ Scenario: From the browser I can successfully upload a picture:
https://recordit.co/abSv8lOWsg

✅ Scenario: Address bar:
https://recordit.co/6Uec0C1Gf6

✅ Scenario: Adding browser Favorites:
https://recordit.co/B68AIbzIo9

✅ Scenario: Browser Options Menu:
Browser back button - https://recordit.co/bM5nCwdS87
Reload, Share, Network change in wallet, & New Tab - https://recordit.co/l1DPOMwVRM

✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning:
https://recordit.co/3uyjyalc0C

✅ Scenario: Navigate to pancakeswap.finance and connect wallet account
https://recordit.co/7lCIAZ53Ig

Network regression
✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow:
❗ "Do you want to remove this network" message doesn’t appear
https://recordit.co/BCWpDBXZiu

✅ Scenario: I can remove a custom network that was added via the custom network flow.
❗ "Do you want to remove this network" message doesn’t appear
https://recordit.co/vUjDPZ4JYC

✅ Scenario Outline: Adding a network via a Dapp:
https://recordit.co/lpdBivadkh

✅ Scenario Outline: Adding a network via the new popular network flow:
❗ Poygon - “This network URL doesn’t match a known provider for this chain ID” appears
❗ BNB - “This network URL doesn’t match a known provider for this chain ID” &
“It looks like this network’s display name doesn’t match its chain ID” appear
https://recordit.co/srL9e8qCCv

✅ Scenario: Adding a network via the custom network flow:
https://recordit.co/3evlIUzVFU

✅ Scenario: Adding a custom network and editing the network:
https://recordit.co/hkdCKN27W8

✅ Scenario: Editing a popular network:
https://recordit.co/GeTcbA7dJK

Nick-Son · 2024-02-25T21:57:03Z

Network Regression:
✅ Scenario: I can remove a custom network (Palm) that was added via the popular network flow:
https://drive.google.com/file/d/1hU3IuWnJp-dpLtJvQJzPMyG4cS0J3Tew/view?usp=drive_link
✅ Scenario: I can remove a custom network that was added via the custom network flow. NOTE: The alert message with the text "Do you want to remove this network" does not appear
https://drive.google.com/file/d/1hNP_2MhAVABdx-90Z7iKaPsKU4vMtME4/view?usp=drive_link
✅ Scenario Outline: Adding a network via a Dapp:
https://drive.google.com/file/d/1hN3u2vEteYSxqO_vn3P4Dmwc6sqhZ1DO/view?usp=drive_link
✅ Scenario Outline: Adding a network via the new popular network flow:
https://drive.google.com/file/d/1hMrYR9ORZbGLZ0nz3Z1xt1C0frpCbNdE/view?usp=drive_link
✅ Scenario: Adding a network via the custom network flow:
https://drive.google.com/file/d/1hL0DP1Vs2KBTncnCugUn6fVLZiGc4vz5/view?usp=drive_link
✅ Scenario: Adding a custom network and editing the network:
https://drive.google.com/file/d/1hGWFFP3QBkjFXtCYDiy_CbAzLROZ_Zc3/view?usp=drive_link
✅ Scenario: Editing a popular network:
https://drive.google.com/file/d/1hGFHG0FxeT1CYZ3pih3E6F6oRtl8C-JQ/view?usp=drive_link

Browser Regression:
✅ Scenario: Searching an invalid url and prompts the user with an error message:
https://drive.google.com/file/d/1h59b9uRlCM7jNfnT9GeXpgIXXn6mbkTL/view?usp=drive_link
✅ Scenario: Navigation with browser controls:
https://drive.google.com/file/d/1h-nA5SoBUqnNrpC95_Mq6oKh6CoM0sWo/view?usp=drive_link
✅ Scenario: ENS website loads correctly:
https://drive.google.com/file/d/1gyWLacLD5pN50uvu9U7t2zZ91aGOKYX-/view?usp=drive_link
✅ Scenario: From the browser I can successfully upload a picture:
https://drive.google.com/file/d/1gyQxfzThGRA5dksf7IGV1rk_eJrgZnmr/view?usp=drive_link
✅ Scenario: Address bar:
https://drive.google.com/file/d/1gnhuo6qkZewrUdGAzIcx1ehG-dzsmHKz/view?usp=drive_link
✅ Scenario: Adding browser Favorites:
https://drive.google.com/file/d/1gnCqNPqhAOlPWmhk7iRXz9ckJ5j-yFWO/view?usp=drive_link

Name field was not pre populated with "Uniswap Interface"
At step #13, the page would not load, I had to close the tab and open a new one
On the favorites tab, the newly created favorite could not load the icon

✅ Scenario: Visiting a malicious website prompts the user with the phishing detection warning:
https://drive.google.com/file/d/1gmbVVmnc4o3QTJPisxnbRc7jH7_cSWvr/view?usp=drive_link
✅ Scenario: Navigate to pancakeswap.finance and connect wallet account
https://drive.google.com/file/d/1gjE4Fw8BuQs2woS6M8W9OktSjP2BIjRR/view?usp=drive_link
✅ Scenario: Browser Options Menu:
https://drive.google.com/file/d/1gdnRA0y9Or7eW8oJkq5Sj5Xcce4vhcCm/view?usp=drive_link

Setting: General View:
✅ Scenario: Changing the device language from English to Russian:
https://drive.google.com/file/d/1hnz-tmaDD0VQDB-Nn8zAYkVfUGCSHSsd/view?usp=drive_link
✅ Scenario: Changing the app language from English to Filipino:
https://drive.google.com/file/d/1hjIaOyAKROqst_5Rz9n1V3rIhjnfDEFH/view?usp=drive_link

Onboarding: Custom ETH Mainnet:
✅ Custom main net Scenario 1 (Verifying Custom Mainnet Screen Appears):
https://drive.google.com/file/d/1fmI4hv4qAhVAua_ET9f33CBO25bWt7Qv/view?usp=drive_link
✅ Custom main net Scenario 2 (Entering an Invalid Mainnet RPC URL):
https://drive.google.com/file/d/1fhDF39GrvYl28LmXo86UNzg_DDe75e9q/view?usp=drive_link
✅ Custom main net Scenario 3 (Entering a valid Mainnet RPC URL):
https://drive.google.com/file/d/1ffFnMJkk7G-d4PWNdasG4lbOjjNOWk3C/view?usp=drive_link
✅ Custom main net Scenario 4 (Editing a custom main net URL on the settings and privacy view):
https://drive.google.com/file/d/1faRV8pTwyCs80D87JIi7kVB686BleFfm/view?usp=drive_link
✅ Custom main net Scenario 5 (Deleting a custom mainnet URL on the settings and privacy view):
https://drive.google.com/file/d/1f_FhdjPM04tH4GqeGpCYxaGkFVyR5ROh/view?usp=drive_link

QR Scanner Regression:
✅ From the in-app camera I should be able to scan a valid QR code containing an address:
https://drive.google.com/file/d/1gHQbR_WDYQWRJX2DmHp3nHUKDhdXfm0c/view?usp=drive_link
✅ I should be able to use the QR scanner on the send flow to scan an address:
https://drive.google.com/file/d/1gFUkzGMKoQPKVbWFyrXvPHeytDmoylJ0/view?usp=drive_link
✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message:
https://drive.google.com/file/d/1g3SvcePq-qo0w664DsDGNqG613KcQCk5/view?usp=drive_link
✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message:
https://drive.google.com/file/d/1g1J9IKydA22FLI5KNf5OAwOhx3UXBPR0/view?usp=drive_link
❌ When I scan an invalid address QR code using the in app camera I should see the appropriate warning message: FAILED - no warning message:
https://drive.google.com/file/d/1g0eunsHFs2l7V2nQWg2Afy8Fv32gPyZ1/view?usp=drive_link
✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message:
https://drive.google.com/file/d/1fwidcseRirit5JSU3hS4aFCkRe4s8G9S/view?usp=drive_link
✅ A user can scan a private key QR code using the in-app camera to import an account:
https://drive.google.com/file/d/1ftlvppA80jgOll0bll53dlzAFRJkf5nM/view?usp=drive_link
✅ User scans MMM Receive QR code on different network:
https://drive.google.com/file/d/1gK8LmeZgwdam6AaYgEcLnhSMjy8r3nyI/view?usp=drive_link

leotm · 2024-02-26T13:00:56Z

Changes from team-lavamoat for 7.17.0 should be working as expected
(nb: this is #8373 already cherry-picked in 7.16.0) cc @SamuelSalas

plasmacorral · 2024-02-27T15:11:29Z

🟢 Approval on Behalf of the Hardware wallets team

After testing and consultation with the product manager, it's confirmed that none of the identified issues are launch-blocking. This approval is delivered on behalf of the Hardware wallets team, to include PR 8246 within release 7.17.0

## **Description** This PR cherry-picks #[8632](#8632) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46e749cb-c149-4ced-bc40-a9e5e1bed3c8 Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88873d22-4fea-45c3-83f3-eb034aa3ee32 ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: MetaMask Bot <37885440+metamaskbot@users.noreply.github.com>

SamuelSalas · 2024-02-29T00:12:13Z

🟢 QA SIgn off from Team Mobile platform

✅ fix: Cherry pick translations #8773
✅ New Crowdin translations by Github Action #8632
✅ fix: Custom network chain id not converted to hexadecimal format #8606
✅ fix: missing converting to decimal chain id on network verification of pop… #8592
✅ fix: revert slice engine #8587
✅ ci: Exclude ip package from audit #8563
✅ fix: Commit script diff that appears when building iOS #8559
✅ test: add blacklist URLs to automated tests #8558
✅ test: use fast swipe on account sheet modal #8541
✅ feat: Feature/1300 dapp visit event #8520
✅ fix: Update MixPanel proxy URL #8517
✅ fix: Fix/8352 source map stack trace #8509
✅ fix: Revert "fix: Fix/8352 source map stack trace (#8467)" #8508
✅ fix: clarify cherry pick action inputs #8500
✅ fix: Cleanup/miscellaneous #8488
✅ chore: bumping code coverage thresholds #8478
✅ fix: Fix/8352 source map stack trace #8467
✅ feat: Update assets controllers v^9.0.0 #8378
✅ feat: Update network controller v^10 #8370
✅ test: 1452 refactor modal pages batch 2 #8257
✅ fix: Update navigation bar on start loading #8126
✅ feat: chain id to hexadecimal format #7999

Cherry-pick fix for #8725 on version 7.17.0. Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

Cherry-pick fix for #8742 on version 7.17.0.

This PR cherry-picks #8744 Co-authored-by: salimtb <salim.toubal@outlook.com>

Cherry-pick fix for #8727 on version 7.17.0.

Cherry-pick fix for #8708 on version 7.17.0. --------- Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>

## **Description** Chore to bump release version ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

seaona · 2024-03-01T08:40:13Z

🟢 This is the QA Sign Off from Confirmations UX.

Main checks

🟢 Blockaid is enabled by default both in fresh installs and migrations for android and ios
🟢 Copy for benign messages has been updated fix: change in blockaid alert message #8725
🟢 Origin is set to metamask for inner wallet transactions fix: update origin passed to ppom for send transactions #8742
🟢 Friction modal has been removed for ios feat: remove friction modal for enabling the feature from settings on iOS #8552

Issues

Some identified issues (non blockers):

Screenshots

enabled-default-migration.mov

origin-metamask.mp4

github-actions · 2024-03-01T19:27:29Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a3a413e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/409d8a92-38ba-4e62-9341-67c630d168ea

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-03-01T19:36:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

SamuelSalas · 2024-03-01T19:41:35Z

v7.17.0 build 1267 RC2 has QA Sign-off

Cal-L

LGTM

7.17.0

b6667ce

metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 16, 2024

sethkfman added the team-mobile-platform label Feb 16, 2024

updated changelog

1c678b7

metamaskbot mentioned this pull request Feb 24, 2024

chore: cherry pick 8615 #8640

Merged

13 tasks

metamaskbot mentioned this pull request Feb 28, 2024

fix: Cherry pick translations #8773

Merged

26 tasks

blackdevelopa and others added 3 commits February 28, 2024 17:46

fix: cherry-pick (#8725) (#8767)

e0b5f71

Cherry-pick fix for #8725 on version 7.17.0. Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

fix: cherry-pick (#8742) (#8765)

9c11aac

Cherry-pick fix for #8742 on version 7.17.0.

chore: cherry-pick #8744 (#8757)

3f48fe2

This PR cherry-picks #8744 Co-authored-by: salimtb <salim.toubal@outlook.com>

fix: cherry-pick (#8727) (#8766)

bf433de

Cherry-pick fix for #8727 on version 7.17.0.

metamaskbot mentioned this pull request Feb 29, 2024

fix: cherry-pick (#8727) #8766

Merged

chore: cherry-pick #8708 (#8760)

5e2d228

Cherry-pick fix for #8708 on version 7.17.0. --------- Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>

metamaskbot mentioned this pull request Feb 29, 2024

chore: cherry-pick #8708 #8760

Merged

Merge branch 'main' into release/7.17.0

a3a413e

sethkfman marked this pull request as ready for review March 1, 2024 19:25

sethkfman requested a review from a team as a code owner March 1, 2024 19:25

sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 1, 2024

Cal-L approved these changes Mar 1, 2024

View reviewed changes

Cal-L merged commit c575f53 into main Mar 1, 2024
33 of 35 checks passed

github-actions bot locked and limited conversation to collaborators Mar 1, 2024

metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Mar 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.17.0 #8612

7.17.0 #8612

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

brianacnguyen commented Feb 22, 2024

gantunesr commented Feb 23, 2024

katkopel commented Feb 25, 2024 •

edited

Loading

Nick-Son commented Feb 25, 2024

leotm commented Feb 26, 2024

plasmacorral commented Feb 27, 2024 •

edited

Loading

SamuelSalas commented Feb 29, 2024

seaona commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Mar 1, 2024

SamuelSalas commented Mar 1, 2024

Cal-L left a comment

7.17.0 #8612

7.17.0 #8612

Conversation

github-actions bot commented Feb 16, 2024

github-actions bot commented Feb 16, 2024

brianacnguyen commented Feb 22, 2024

gantunesr commented Feb 23, 2024

katkopel commented Feb 25, 2024 • edited Loading

Nick-Son commented Feb 25, 2024

leotm commented Feb 26, 2024

plasmacorral commented Feb 27, 2024 • edited Loading

SamuelSalas commented Feb 29, 2024

seaona commented Mar 1, 2024 • edited Loading

Main checks

Issues

Screenshots

github-actions bot commented Mar 1, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Mar 1, 2024

Quality Gate passed

SamuelSalas commented Mar 1, 2024

Cal-L left a comment

Choose a reason for hiding this comment

katkopel commented Feb 25, 2024 •

edited

Loading

plasmacorral commented Feb 27, 2024 •

edited

Loading

seaona commented Mar 1, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited by metamaskbot

Loading