Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support durations in snap_scheduleBackgroundEvent #2965

Closed
hmalik88 opened this issue Dec 17, 2024 · 0 comments · Fixed by #2975
Closed

Support durations in snap_scheduleBackgroundEvent #2965

hmalik88 opened this issue Dec 17, 2024 · 0 comments · Fixed by #2975
Assignees
@hmalik88

Comments

@hmalik88
Copy link
Contributor

No description provided.

@hmalik88 hmalik88 self-assigned this Dec 17, 2024
@hmalik88 hmalik88 mentioned this issue Dec 17, 2024
Merged
@hmalik88 hmalik88 mentioned this issue Dec 25, 2024
Merged
@FrederikBolding FrederikBolding changed the title Write util that handles creating an ISO 8601 string for snap_scheduleBackgroundEvent Support durations in snap_scheduleBackgroundEvent Jan 7, 2025
hmalik88 added a commit that referenced this issue Jan 7, 2025
@hmalik88
Add logic to allow ISO 8601 duration strings (#2975)
7e3ef0b 
Closes #2965  

This eliminates the need for some util to provide devs to make it easier
to schedule an event. The ISO 8601 standard already provides us with
[Durations](https://en.wikipedia.org/wiki/ISO_8601#Durations). Luxon
provides a class to parse them and as such we can accept duration
strings as well to make it simpler to schedule an event.
Mrtenz pushed a commit that referenced this issue Jan 8, 2025
@hmalik88 @Mrtenz
Add logic to allow ISO 8601 duration strings (#2975)
c629594 
Closes #2965  

This eliminates the need for some util to provide devs to make it easier
to schedule an event. The ISO 8601 standard already provides us with
[Durations](https://en.wikipedia.org/wiki/ISO_8601#Durations). Luxon
provides a class to parse them and as such we can accept duration
strings as well to make it simpler to schedule an event.
PatrykLucka pushed a commit that referenced this issue Jan 13, 2025
@hmalik88 @PatrykLucka
Add logic to allow ISO 8601 duration strings (#2975)
2753e13 
Closes #2965  

This eliminates the need for some util to provide devs to make it easier
to schedule an event. The ISO 8601 standard already provides us with
[Durations](https://en.wikipedia.org/wiki/ISO_8601#Durations). Luxon
provides a class to parse them and as such we can accept duration
strings as well to make it simpler to schedule an event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmalik88 hmalik88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logic to allow ISO 8601 duration strings MetaMask/snaps
1 participant
@hmalik88