Add logic to allow ISO 8601 duration strings #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2975 +/- ##
=======================================
Coverage 94.71% 94.72%
=======================================
Files 497 497
Lines 10802 10818 +16
Branches 1649 1652 +3
=======================================
+ Hits 10231 10247 +16
Misses 571 571 ☔ View full report in Codecov by Sentry. |
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Jan 7, 2025
packages/snaps-rpc-methods/src/permitted/scheduleBackgroundEvent.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
previously approved these changes
Jan 7, 2025
FrederikBolding
approved these changes
Jan 7, 2025
Mrtenz
pushed a commit
that referenced
this pull request
Jan 8, 2025
Closes #2965 This eliminates the need for some util to provide devs to make it easier to schedule an event. The ISO 8601 standard already provides us with [Durations](https://en.wikipedia.org/wiki/ISO_8601#Durations). Luxon provides a class to parse them and as such we can accept duration strings as well to make it simpler to schedule an event.
PatrykLucka
pushed a commit
that referenced
this pull request
Jan 13, 2025
Closes #2965 This eliminates the need for some util to provide devs to make it easier to schedule an event. The ISO 8601 standard already provides us with [Durations](https://en.wikipedia.org/wiki/ISO_8601#Durations). Luxon provides a class to parse them and as such we can accept duration strings as well to make it simpler to schedule an event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2965
This eliminates the need for some util to provide devs to make it easier to schedule an event. The ISO 8601 standard already provides us with Durations. Luxon provides a class to parse them and as such we can accept duration strings as well to make it simpler to schedule an event.