-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement SIP-29 permission and handlers #3028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/sip29
branch
3 times, most recently
from
January 22, 2025 11:51
2ef1a45
to
d194133
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
+ Coverage 94.76% 94.80% +0.04%
==========================================
Files 500 503 +3
Lines 10911 10996 +85
Branches 1672 1685 +13
==========================================
+ Hits 10340 10425 +85
Misses 571 571 ☔ View full report in Codecov by Sentry. |
Mrtenz
requested changes
Jan 22, 2025
packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts
Outdated
Show resolved
Hide resolved
packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts
Outdated
Show resolved
Hide resolved
GuillaumeRx
reviewed
Jan 22, 2025
GuillaumeRx
reviewed
Jan 22, 2025
GuillaumeRx
reviewed
Jan 22, 2025
Mrtenz
requested changes
Jan 23, 2025
Mrtenz
approved these changes
Jan 23, 2025
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
FrederikBolding
force-pushed
the
fb/sip29
branch
from
January 23, 2025 10:18
97e434c
to
cb67728
Compare
GuillaumeRx
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
endowment:assets
permission that lets Snaps exposeOnAssetsLookup
andOnAssetsConversion
. These handlers are going to be called by controllers responsible for managing non-EVM assets. This PR is mostly adding support for those handlers, as well as the types/structs required to validate the parameters and responses. Additionally some work was done to transform the responses to filter out any out of scope assets returned.For reference: https://metamask.github.io/SIPs/SIPS/sip-29