Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement SIP-29 permission and handlers #3028

Merged
merged 17 commits into from
Jan 23, 2025
Merged

feat: Implement SIP-29 permission and handlers #3028

merged 17 commits into from
Jan 23, 2025

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jan 21, 2025

Add an endowment:assets permission that lets Snaps expose OnAssetsLookup and OnAssetsConversion. These handlers are going to be called by controllers responsible for managing non-EVM assets. This PR is mostly adding support for those handlers, as well as the types/structs required to validate the parameters and responses. Additionally some work was done to transform the responses to filter out any out of scope assets returned.

For reference: https://metamask.github.io/SIPs/SIPS/sip-29

@FrederikBolding FrederikBolding force-pushed the fb/sip29 branch 3 times, most recently from 2ef1a45 to d194133 Compare January 22, 2025 11:51
@FrederikBolding FrederikBolding marked this pull request as ready for review January 22, 2025 13:05
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 22, 2025 13:05
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (277b974) to head (cb67728).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3028      +/-   ##
==========================================
+ Coverage   94.76%   94.80%   +0.04%     
==========================================
  Files         500      503       +3     
  Lines       10911    10996      +85     
  Branches     1672     1685      +13     
==========================================
+ Hits        10340    10425      +85     
  Misses        571      571              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 78dd810 into main Jan 23, 2025
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/sip29 branch January 23, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants