Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement SIP-29 permission and handlers #3028

Merged
merged 17 commits into from
Jan 23, 2025
+1,241 −19
Merged

feat: Implement SIP-29 permission and handlers #3028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5d88a74
feat: Implement SIP-29 permission and handlers
FrederikBolding Jan 21, 2025
071d8aa
Add test for execution handlers
FrederikBolding Jan 21, 2025
bf6737a
Add basic structs/types
FrederikBolding Jan 21, 2025
80f5142
Add struct tests
FrederikBolding Jan 22, 2025
111f200
Assert response types
FrederikBolding Jan 22, 2025
87889f5
Add parameter validation
FrederikBolding Jan 22, 2025
027a2be
Add result transformers
FrederikBolding Jan 22, 2025
cffea47
Add additional tests, update manifest and LM policy
FrederikBolding Jan 22, 2025
ef721fd
Update manifests and coverage again
FrederikBolding Jan 22, 2025
aa396c7
Update coverage
FrederikBolding Jan 22, 2025
fdf7934
Another coverage tweak
FrederikBolding Jan 22, 2025
8a1f5d5
Apply suggestions from code review
FrederikBolding Jan 22, 2025
eb19f8c
Address PR review comments
FrederikBolding Jan 22, 2025
1696fb1
Refactor slightly
FrederikBolding Jan 22, 2025
ee86bd7
Add JSDoc
FrederikBolding Jan 23, 2025
5b61497
Add test for uncovered validation function
FrederikBolding Jan 23, 2025
cb67728
Update coverage
FrederikBolding Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/examples/packages/browserify-plugin/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "B0senywfM+w5lQ+iMvK+bVcKJ6VeLDj7HiUVYR5Cuag=",
"shasum": "PU8/QaQOlO6/ShRIM+jofaiQFUAprfuUX9RV6G5xRJo=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/packages/browserify/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snaps.git"
},
"source": {
"shasum": "PS0U7SHYXWpFhO8QMtArHKU1rFzMkwtTLFlc3/g1HQ4=",
"shasum": "5vUCvHpbE8BnQv9R8QorYcvyKPZk0s+Fuh/MFUZ7LH4=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand Down
8 changes: 4 additions & 4 deletions packages/snaps-controllers/coverage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"branches": 92.96,
"functions": 96.56,
"lines": 98.05,
"statements": 97.77
"branches": 93.06,
"functions": 96.59,
"lines": 98.08,
"statements": 97.8
}
Loading
Loading