-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload headshots to S3 via django-storages #1134
Changes from 16 commits
c075b35
f6fb20d
ccbc3dd
c8340e5
afe2d5e
87f67e9
2b7faba
7a3e127
bb3ae93
e2fa08d
66b9813
0031438
3ecb2ca
2d61285
aab9e4c
99918fa
3c00ced
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
SMART_LOGIC_KEY= | ||
ANALYTICS_TRACKING_CODE= | ||
REMOTE_ANALYTICS_FOLDER= | ||
SENTRY_DSN= | ||
AWS_S3_ACCESS_KEY_ID= | ||
AWS_S3_SECRET_ACCESS_KEY= | ||
AWS_STORAGE_BUCKET_NAME=la-metro-headshots-staging | ||
RECAPTCHA_PUBLIC_KEY= | ||
RECAPTCHA_PRIVATE_KEY= | ||
GOOGLE_API_KEY= | ||
GOOGLE_SERVICE_ACCT_API_KEY= |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,4 +64,5 @@ jobs: | |
run: | | ||
flake8 . | ||
black --check . | ||
cp .env.local.example .env.local | ||
pytest -sv |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
FROM ghcr.io/metro-records/la-metro-councilmatic:main | ||
|
||
RUN apt-get update && \ | ||
apt-get install -y git | ||
|
||
COPY ./requirements.txt /app/requirements.txt | ||
RUN pip install pip==24.0 && \ | ||
pip install --no-cache-dir -r requirements.txt |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line 17 here refers to a legacy way of running the app without docker. is this still useful to us? those old docs talk about using Solr which has been removed here, so they're also out of date. If we want to keep the reference to the old magicks, we could maybe change the language to something like:
The line in question: la-metro-councilmatic/README.md Line 17 in 04df15e
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great call. Since we don't run apps without Docker any more, I just removed the reference to the old setup instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Need
git
to installdjango-councilmatic
from the branch, will remove when new release is cut.