Change m_fPreemptiveGCDisabled to bool (dotnet/coreclr#27648)

Commit migrated from dotnet/coreclr@96e08af
MichalStrehovsky · Mar 31, 2020 · d003e6a · d003e6a
1 parent bd767af
commit d003e6a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/src/Native/gc/sample/gcenv.ee.cpp b/src/Native/gc/sample/gcenv.ee.cpp
@@ -177,19 +177,14 @@ bool GCToEEInterface::IsPreemptiveGCDisabled()
 
 bool GCToEEInterface::EnablePreemptiveGC()
 {
-    bool bToggleGC = false;
     Thread* pThread = ::GetThread();
-
-    if (pThread)
+    if (pThread && pThread->PreemptiveGCDisabled())
     {
-        bToggleGC = !!pThread->PreemptiveGCDisabled();
-        if (bToggleGC)
-        {
-            pThread->EnablePreemptiveGC();
-        }
+        pThread->EnablePreemptiveGC();
+        return true;
     }
 
-    return bToggleGC;
+    return false;
 }
 
 void GCToEEInterface::DisablePreemptiveGC()

diff --git a/src/Native/gc/sample/gcenv.h b/src/Native/gc/sample/gcenv.h
@@ -92,7 +92,7 @@ struct alloc_context;
 
 class Thread
 {
-    uint32_t m_fPreemptiveGCDisabled;
+    bool m_fPreemptiveGCDisabled;
     uintptr_t m_alloc_context[16]; // Reserve enough space to fix allocation context
 
     friend class ThreadStore;
@@ -105,7 +105,7 @@ class Thread
 
     bool PreemptiveGCDisabled()
     {
-        return !!m_fPreemptiveGCDisabled;
+        return m_fPreemptiveGCDisabled;
     }
 
     void EnablePreemptiveGC()

diff --git a/src/Native/gc/unix/events.cpp b/src/Native/gc/unix/events.cpp
@@ -146,7 +146,7 @@ class GCEvent::Impl
             TimeSpecAdd(&endTime, milliseconds);
         }
 #else
-#error "Don't know how to perfom timed wait on this platform"
+#error "Don't know how to perform timed wait on this platform"
 #endif
 
         int st = 0;