This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Reduce unneeded forcing to boolean #27648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Nov 3, 2019
|
Thank you! |
jkotas
reviewed
Nov 3, 2019
jkotas
reviewed
Nov 3, 2019
jkotas
reviewed
Nov 4, 2019
jkotas
reviewed
Nov 4, 2019
|
Fixed |
jkotas
reviewed
Nov 4, 2019
jkotas
reviewed
Nov 4, 2019
ghost
changed the title
jkotas
approved these changes
Nov 4, 2019
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Mar 28, 2020
Commit migrated from dotnet/coreclr@96e08af
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Mar 31, 2020
Commit migrated from dotnet/coreclr@96e08af
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 1, 2020
Commit migrated from dotnet/coreclr@96e08af
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple of files related to GC, there is the problem in which whenever one runs the getter pThread->PreemptiveGCDisabled(), the getter checks to see if the member variable m_fPreemptiveGCDisabled is 0 or not, AND then the value of that expression is checked to be 1 or 0 AGAIN.
This is unnecessary and now only does this check when running the getter.