Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive window creation fails after a restored one for the same document was closed #11574

Closed
amunger opened this issue Oct 5, 2022 · 2 comments · Fixed by #11575
Closed

Interactive window creation fails after a restored one for the same document was closed #11574

amunger opened this issue Oct 5, 2022 · 2 comments · Fixed by #11575
Assignees
@amunger
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Milestone
October 2022

Comments

@amunger
Copy link
Contributor

amunger commented Oct 5, 2022

repro steps

  1. set "interactiveWindow.restore": true
  2. run a cell from a .py file to create an interactive window
  3. reload VScode
  4. close the restored IW
  5. run a cell from that same file
    🐛 creation fails sometimes:

image
@amunger amunger added the interactive-window Impacts interactive window label Oct 5, 2022
@amunger amunger changed the title Interactive window creation can fail after a restored one for the same document was closed Interactive window creation fails after a restored one for the same document was closed Oct 5, 2022
@amunger
Copy link
Contributor Author

amunger commented Oct 5, 2022

Actually, whether or not you close the previous window, running a cell from a .py file will fail with that error message

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Oct 6, 2022
@rebornix rebornix added this to the October 2022 milestone Oct 6, 2022
@rebornix
Copy link
Member

rebornix commented Oct 6, 2022

@amunger you wanna take a look at how it fails (with the content provider for interactive)?

@amunger amunger transferred this issue from microsoft/vscode Oct 7, 2022
This was referenced Oct 7, 2022
Merged
Closed
@rebornix rebornix added the verified Verification succeeded label Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amunger amunger

Labels
bug Issue identified by VS Code Team member as probable bug interactive-window Impacts interactive window verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

fix interactive window restore microsoft/vscode-jupyter
2 participants
@rebornix @amunger