Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - All Jupyter Shortcuts to be supported #4438

Closed
DonJayamanne opened this issue Jan 21, 2021 · 7 comments
Closed

Native Notebooks - All Jupyter Shortcuts to be supported #4438

DonJayamanne opened this issue Jan 21, 2021 · 7 comments

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jan 21, 2021

Issue #4376 tracked keyboard shortcuts for essentials, but not all.

We need to ensure we support the rest, e.g. O, etc.

Is this GA or Post GA?

@DavidKutu
Copy link

Also do this #5797

@claudiaregio
Copy link
Contributor

Adding this one as well: #5976

@claudiaregio
Copy link
Contributor

#6037

@greazer
Copy link
Member

greazer commented Jun 6, 2021

We need the list of shortcuts needing to be created to be made part of this issue.

For the record now though, #6045 references M and Y to toggle a cell between markdown and code. These are two of the whole set we need to support.

@joyceerhl
Copy link
Contributor

M and Y are already contributed by VS Code core. #6205 resolves all outstanding keybindings tracked by this issue:

  • Shift+enter and ctrl+enter should render markdown cells even in edit mode
  • Jupyter extension should override shift+enter keybinding contributed by VS Code (extension keybindings always trump default core keybindings)
  • Shift+L should toggle line numbers for entire notebook, L should toggle line numbers for current cell

@DavidKutu
Copy link

valdiated

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
@DonJayamanne DonJayamanne reopened this Jul 8, 2021
@DonJayamanne
Copy link
Contributor Author

These are not supported.

Screen Shot 2021-07-07 at 18 34 24

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants