Add "breakpoint created/deleted" notifications.

[vadimcn]

Some debuggers have much more flexible ways of setting breakpoints than VSCode currently supports (e.g. set breakpoints by regex). Would be nice if breakpoints created via commands in debugger console were reflected in the UI.

I'd suggest adding a new notification message to the protocol, which adapter can send when a breakpoint is created/deleted. It should include a "cookie" that needs to be passed back to the adapter in order to re-create the breakpoint.

[weinand]

@vadimcn the protocol has already a BreakpointEvent for this. Please see: https://github.com/Microsoft/vscode-debugadapter-node/blob/master/protocol/src/debugProtocol.ts#L135

@isidorn are you already tracking this event?

[isidorn]

@weinand yes here

[vadimcn]

@weinand: But does VSCode support creation/deleteion? Sending a BreakpointEvent with reason = 'new' doesn't seem to have any effect.
Your comment from February says "VS Code now listens on breakpoint events with reason update and updates the verification state and location". If I read the relevant code, correctly, it indeed only deals with updates of existing breakpoints.

[vadimcn]

Also, please note that currently the Breakpoint does not provide a way to preserve custom information (such as condition, hit count, etc) across debugging sessions.

[isidorn]

@vadimcn you are right, there is no code for dealing with Breakpoint event = 'new' or 'deleted' (@weinand do we want to call this 'deleted'?). Thus reopening this

[isidorn]

Assigning first to @weinand since this needs a couple of more additions to the protocol:

• How do we call an event when a breakpoint got deleted?
• Do we add a possibility that a adapter can also add / remove function breakpoints - if yes we need a way to distinguish those events from adding/removing regular breakpoints
• As mentioned by @vadimcn currently it is not possible for the debug adapter to send a breakpoint with a condition to vscode, so we might need to introduce the condition to the Breakpoint interface in the debug protocol

Once that is done we just need to handle those events here for which a pull request is welcome @vadimcn.

[daviwil]

Hey guys, the PowerShell extension is really in need of this behavior now since we're able to interactively debug PowerShell scripts using our new Integrated Console feature. I've started trying to implement the add/delete behavior for BreakpointEvent in debugService so that I can send you a PR for it to go into the release at the beginning of June. Once I get something basic working I'll send a WIP PR so we can discuss the implementation.

I also noticed the lack of support for the debugger sending condition and function breakpoints to the client. Is that something we could potentially add to the protocol soon? Any way I could help with that?

[isidorn]

After discussing with @weinand we decided to introduce 3 different breakpoint events
"new", "changed" and "removed". @weinand will update the debug protocol and will probably also cover the case that the adapter can update the condition of a breakpoint.

For compatibiliy reason if a breakpoint event has no reason (which is required) I will handle it as a "changed" event.
@roblourens please update the node2 adapter to always send the appropriate reason for breakpoint events(currently it is sending always "new")

[isidorn]

Now vscode will react to breakpoint events.
Please note that a "new" BreakpointEvent requires that a Source is passed. In the future we can consider if adapters can add new function breakpoints with this "new" event.

Unassigning myself and assigning to @weinand to update the protocol and @roblourens to adopt this in node-debug2 adapter.
Even though condition is not specified in the protocl for BreakpointEvent yet vscode should proparly react to this.

@daviwil please try it out and let me know how it goes

[weinand]

For verifying this feature, I've added two REPL command to mock-debug:

• new 12 adds a new breakpoint in line 12 of the source file,
• del 12 deletes a breakpoint in line 12 of the source file.

I found these issues:

• for a newly created breakpoint the "verified" attribute is ignored
• I could not delete a breakpoint

And maybe unrelated:
Breakpoints section is empty #35179

[isidorn]

@weinand thanks for verifying and for nicely updating the mock debug so this is easy to try out.
I have pushed a fix for both issues specified here, as for the section being empty I will tackle that in that seperate issue.

[weinand]

Now its working fine.