Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Middleware #38

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Using Middleware #38

merged 8 commits into from
Nov 21, 2023

Conversation

gpltaylor
Copy link
Contributor

Add documentation showing how to implement Middleware when using Kiota.

Document how to implement Middleware into Kiota
Improve wording
@gpltaylor gpltaylor requested a review from a team as a code owner November 21, 2023 10:30
Copy link
Contributor

Learn Build status updates of commit b529d09:

💡 Validation status: suggestions

File Status Preview URL Details
OpenAPI/kiota/middleware.md 💡Suggestion Details

OpenAPI/kiota/middleware.md

  • Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'gpltaylor' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gpltaylor
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="{Fluent Money}"]

Add Middleware to Concept page
Copy link
Contributor

Learn Build status updates of commit 0ae0cfc:

💡 Validation status: suggestions

File Status Preview URL Details
OpenAPI/kiota/middleware.md 💡Suggestion Details
OpenAPI/kiota/index.yml ✅Succeeded

OpenAPI/kiota/middleware.md

  • Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'gpltaylor' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit d7686e0:

⚠️ Validation status: warnings

File Status Preview URL Details
OpenAPI/kiota/middleware.md ⚠️Warning Details
OpenAPI/kiota/index.yml ✅Succeeded

OpenAPI/kiota/middleware.md

  • Line 2, Column 1: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gpltaylor
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Fluent Money"

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Let's start with a couple of linting aspects.

OpenAPI/kiota/middleware.md Outdated Show resolved Hide resolved
OpenAPI/kiota/middleware.md Outdated Show resolved Hide resolved
OpenAPI/kiota/middleware.md Show resolved Hide resolved
OpenAPI/kiota/middleware.md Show resolved Hide resolved
OpenAPI/kiota/middleware.md Show resolved Hide resolved
OpenAPI/kiota/middleware.md Outdated Show resolved Hide resolved
OpenAPI/kiota/middleware.md Outdated Show resolved Hide resolved
OpenAPI/kiota/middleware.md Outdated Show resolved Hide resolved
OpenAPI/kiota/middleware.md Show resolved Hide resolved
OpenAPI/kiota/middleware.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 5d51774:

⚠️ Validation status: warnings

File Status Preview URL Details
OpenAPI/kiota/middleware.md ⚠️Warning Details
OpenAPI/kiota/index.yml ✅Succeeded

OpenAPI/kiota/middleware.md

  • Line 51, Column 1: [Warning: code-block-unclosed - See documentation] Unclosed code block. Code blocks must begin and end with triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for the contribution!

@baywet baywet enabled auto-merge November 21, 2023 14:15
Copy link
Contributor

Learn Build status updates of commit 3d25edb:

✅ Validation status: passed

File Status Preview URL Details
OpenAPI/kiota/index.yml ✅Succeeded
OpenAPI/kiota/middleware.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@baywet baywet merged commit f14b9c3 into MicrosoftDocs:main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants