Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button function call #2355

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Fix button function call #2355

merged 5 commits into from
Apr 26, 2024

Conversation

AlvinSchiller
Copy link
Collaborator

@AlvinSchiller AlvinSchiller commented Apr 23, 2024 •
edited
Loading

Addresses #2337, follow up to #2266.
Using a RotaryEncoder produced errors, due to an incorrect parameter handling.

  • add functionArgs for RotaryEncoder to be able to use other functions than "volume"
  • fix parameter order. If defined functionArgs take precedence over given parameter.
  • fix parameter for functionCalls to handle "additional parameter" to support RotaryEncoder.
  • update docs and wiki
    • removed obsolete example files
    • Merged and removed Wiki page "Audio-RotaryKnobVolume"

@AlvinSchiller
fix: handle args for rotaryEncoder
d667a2f 
don't pass args to callback if 'None'.
reorder args for callback to pass functionCallArgs first, if definied.
added functionCallArgs to rotaryEncoder definition, to support other functionCalls then volume.
@AlvinSchiller
doc: update docs. removed duplicate / obsolete examples
424e870 
Merged wiki page "Audio-RotaryKnobVolume"
@AlvinSchiller
fix: fix tests
53eac6a
@AlvinSchiller AlvinSchiller added bug legacy_v2 Issues, discussions and PRs related to Version 2.x labels Apr 23, 2024
@AlvinSchiller AlvinSchiller added this to the v2.7.0 milestone Apr 23, 2024
@AlvinSchiller AlvinSchiller self-assigned this Apr 23, 2024
@coveralls
Copy link

coveralls commented Apr 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8842815532

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 78.51%
Totals Coverage Status
Change from base Build 8795852446: 0.08%
Covered Lines: 453
Relevant Lines: 577
💛 - Coveralls

@AlvinSchiller @s-martin
Apply suggestions from code review
05ece20 
Co-authored-by: s-martin <s-martin@users.noreply.github.com>
s-martin
s-martin approved these changes Apr 25, 2024
View reviewed changes
components/gpio_control/README.md Outdated Show resolved Hide resolved
@AlvinSchiller @s-martin
Update codeblock type
155de62 
Co-authored-by: s-martin <s-martin@users.noreply.github.com>
@AlvinSchiller AlvinSchiller merged commit 8069179 into MiczFlor:develop Apr 26, 2024
27 checks passed
@AlvinSchiller AlvinSchiller deleted the fix/button_functionCall branch April 26, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-martin s-martin s-martin approved these changes

Assignees

@AlvinSchiller AlvinSchiller

Labels
bug legacy_v2 Issues, discussions and PRs related to Version 2.x
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvinSchiller @coveralls @s-martin