Fixing issue with test failures on CentOS #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatkinson
force-pushed
the
fix_time_test_failures
branch
from
669e15f
to
f82b3f4
Compare
calccrypto
reviewed
Aug 14, 2023
calccrypto
reviewed
Aug 14, 2023
calccrypto
reviewed
Aug 14, 2023
calccrypto
reviewed
Aug 14, 2023
calccrypto
reviewed
Aug 14, 2023
bwatkinson
force-pushed
the
fix_time_test_failures
branch
from
f82b3f4
to
2abade5
Compare
calccrypto
reviewed
Sep 7, 2023
calccrypto
reviewed
Sep 7, 2023
bwatkinson
force-pushed
the
fix_time_test_failures
branch
from
b71b3a8
to
48e2dd5
Compare
Merged
calccrypto
approved these changes
Sep 11, 2023
|
@MigeljanImeri after you have reviewed and approved I will squash these commits into one and then merge it into master. |
MigeljanImeri
approved these changes
Sep 12, 2023
The following two tests would always fail on my CentOS 8 box: 1. test_xdd_passdelay 2. test_xdd_startdelay The issue was that the time package was not installed. I updated the build system to check if it is installed. If it is not installed, CMake will state that both the tests test_xdd_passdelay and test_xdd_startdelay will be skipped when running ctest. If it is installed all tests will run like normal with the time command using the proper path to the binary (/usr/bin/time). I also updated the main README to state that time is an optional dependency. I did a little bit of cleanup in the test directory. I got rid of the test_config.example as that was used for the previous way to run the tests for XDD. We now set those variables and create the test_config file using the CMakeLists.txt in the test directory. I also got rid of the the run_tests.sh script as that is no longer necessary as we moved to CMake CTest now. Finally, I updated the README file in the test directory to give a description of how to properly add new tests using the CMake CTest infrastructure. Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
bwatkinson
force-pushed
the
fix_time_test_failures
branch
from
48e2dd5
to
4110e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following two tests would always fail on my CentOS 8 box:
The issue was that the time package was not installed. We should make this a requirement as it is needed to run any tests that call the time command. After this update, all tests are passing fine on my CentOS 8 box.