More verbose test errors #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatkinson
force-pushed
the
more_verbose_test_errors
branch
from
8347b92
to
5e076b6
Compare
calccrypto
reviewed
Sep 11, 2023
|
Should shellcheck be run in the CI? https://github.com/mar-file-system/GUFI/blob/master/.github/workflows/check.yml#L83 |
If you want to we can. Feel free to open a PR if you want. |
calccrypto
approved these changes
Sep 12, 2023
MigeljanImeri
approved these changes
Sep 12, 2023
bwatkinson
force-pushed
the
more_verbose_test_errors
branch
from
5e076b6
to
5fc0209
Compare
In general the teets needed to be cleaned up a bit more. This commit does the following: 1. Updated finalize_test to take a 3rd arguement to give more verbose output on failure of skipping of tests. 2. Updated skip routine to return proper error code of 255 for CTest 3. Changed XDDTEST_OUTPUT_DIR -> XDDTEST_LOG_DIR as the naming seemed off when treating the output as a log. 4. Added the fucntion get_log_file to common.sh that let's users get a log file so they can write to it any extra information they want to about the test as it is running. 5. Updated the README in the tests directory to explain the addtition of the get_log_file function. 6. Passed error messages for all tests when doing finalize_tests on error so we can figure out what the error might be. 7. Just some general cleanup with extra spaces etc in tests scripts. In general, most of these tests could also benefit from using the logging as well. However, I will leave that up to another PR for now. fixes #20 Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
bwatkinson
force-pushed
the
more_verbose_test_errors
branch
from
5fc0209
to
1b92701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23 should be merged before this. However, this should help us in figuring out test failures in the future.