Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the Pico #228

Merged
merged 20 commits into from
Jan 5, 2023
Merged

Support for the Pico #228

merged 20 commits into from
Jan 5, 2023

Conversation

elral
Copy link
Collaborator

@elral elral commented Dec 20, 2022

This pull request adds the support for the Raspberry Pi Pico.
The supported board is the original board from the Raspberry Pi Foundation.

  • A environment is added to the platformio.ini file
  • A MFBoards.h file is added for the board specific definitions
  • After writing to the eeprom these changes have to be commited, accordingly MFEEPROM.cpp/h is modified
  • Pico requires it's own servo lib. Therefore the servo lib for Atmels is moved from the standard environment to the boards environment from the Atmel boards
  • The Pico servo lib gets initialized with the same range as for the Atmels
  • The unique ID from the NOR flash gets used instead of a random serial number
  • The device buffer gets initialized with the correct size for this (and other) architectures.

Fixes #225

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

@neilenns
Copy link
Contributor

YES!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@@ -0,0 +1,203 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't checked the .board.json file into this github repo for any of the amtel platforms so this should probably be excluded from this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, you are rigth. Was the best location for me during delelpment.
I will delete it.

platformio.ini Outdated
@@ -61,7 +60,8 @@ build_src_filter =
${env.build_src_filter}
+<../_Boards/Atmel>
lib_deps =
${env.lib_deps}
${env.lib_deps}
arduino-libraries/Servo @ 1.1.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of putting the arduino library in each arduino env, how about creating a new lib_amtel_deps section then including that as ${env.lib_amtel_deps}?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very good idea. I will change this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pair it with a lib_rp2040_deps too, even though there's just one rp2040 platform?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmhm, there are no additional libs for the Pico.

Copy link
Contributor

@neilenns neilenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting! Two minor suggestions. Looks great!

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

Copy link
Contributor

@neilenns neilenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's happening!!! YES!!!

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

@github-actions
Copy link

Firmware for this pull request:
Firmware.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank You so much!

@DocMoebiuz DocMoebiuz merged commit 622a217 into MobiFlight:main Jan 5, 2023
@elral elral deleted the Pico branch January 6, 2023 05:31
@DocMoebiuz DocMoebiuz changed the title Pico Support for the Pico Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the Raspberry Pi Pico
3 participants