-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the Pico #228
Support for the Pico #228
Conversation
Firmware for this pull request: |
YES!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
@@ -0,0 +1,203 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't checked the .board.json file into this github repo for any of the amtel platforms so this should probably be excluded from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, you are rigth. Was the best location for me during delelpment.
I will delete it.
platformio.ini
Outdated
@@ -61,7 +60,8 @@ build_src_filter = | |||
${env.build_src_filter} | |||
+<../_Boards/Atmel> | |||
lib_deps = | |||
${env.lib_deps} | |||
${env.lib_deps} | |||
arduino-libraries/Servo @ 1.1.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of putting the arduino library in each arduino env, how about creating a new lib_amtel_deps
section then including that as ${env.lib_amtel_deps}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, very good idea. I will change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe pair it with a lib_rp2040_deps
too, even though there's just one rp2040 platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmhm, there are no additional libs for the Pico.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So exciting! Two minor suggestions. Looks great!
Firmware for this pull request: |
Firmware for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's happening!!! YES!!!
Firmware for this pull request: |
Firmware for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank You so much!
This pull request adds the support for the Raspberry Pi Pico.
The supported board is the original board from the Raspberry Pi Foundation.
Fixes #225