Bugfix: Pack tests by test count if test estimates are missing or adding up to be zero #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravimandala
force-pushed
the
bugfix-packing-logic
branch
from
55eedfa to
9d94c89
Compare
Splitting the huge testPacking() test into multiple tests. And adding a new test case for packing with missing time estimates, in the provided json file, for new tests in Sample app. Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
ravimandala
force-pushed
the
bugfix-packing-logic
branch
from
9d94c89 to
b5a53d7
Compare
ob
reviewed
Sep 20, 2021
…to zero Signed-off-by: Ravi Mandala <rmandala@linkedin.com>
ravimandala
force-pushed
the
bugfix-packing-logic
branch
from
b5a53d7 to
83c7241
Compare
|
@ob Thanks for the review. Please take another look. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #511 by choosing to pack tests by test count if and when test estimates are missing or adding up to be zero.
\cc @ob @chenxiao0228