-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syntax highlighting for code block #1378
syntax highlighting for code block #1378
Conversation
This is really great – thank you! There are a couple of issues with the original JSON.
|
Thank you for confirming. In the scope of this pull request, we fixed the following changes:
|
That's a good solution. (I vaguely remember that there is a "JSON with Comments" variant in use in some ecosystems. Perhaps in the future that will be a valid identifier for GitHub markdown.)
Perfect. Thank you! We'll get this merged. |
I have merged this. It will be available in the next code-drop. |
I recently remembered this comment, and on GitHub, if you use the
"include": [
/* other includes here */
"$(MODULES)/drivers/destm32s/manifest.json",
],
"include": [
/* other includes here */
"$(MODULES)/drivers/destm32s/manifest.json",
], |
Thanks for remembering this! I've updated the markdown to use "jsonc" where appropriate. That should be available shortly. |
In my translation work, I found that some code blocks do not have syntax highlighting set. I believe that setting syntax highlighting will make the document easier to read and will also help to notice mistakes in the code blocks.
Therefore, there might be some parts where corrections were missed, but I made corrections as much as possible.