Optimize Bootstrap to pre build faster by using multiple threads #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divide up the work into multiple queues, and send those tasks back into the executor. This lets us precache everything concurrently, reducing precache time by about 75%~ on a typical 8 core system. Bootstrap time was seen taking up to 30 seconds of time in testing, which is long enough in Minecraft that data conversions may need to occur. This brought it down to about 6-7 seconds.
aikar
commented
Oct 12, 2018
| List<List<Runnable>> queueList = new ArrayList<>(); | ||
| List<Runnable> current = new ArrayList<>(); | ||
| queueList.add(current); | ||
| int maxTasks = (int) Math.max(1, Math.floor(allTasks.size() / (float)Math.min(6, Runtime.getRuntime().availableProcessors()-2))); |
There was a problem hiding this comment.
I decided to do -2 on core count to not hog every thread, leaving 1 for game and 1 extra as a max, and an overall cap of 6 for systems with many cores overall.
|
Comparison: |
kashike
reviewed
Oct 12, 2018
Dinnerbone
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide up the work into multiple queues, and send those tasks
back into the executor.
This lets us precache everything concurrently, reducing precache
time by about 75%~ on a typical 8 core system.
Bootstrap time was seen taking up to 30 seconds of time in testing,
which is long enough in Minecraft that data conversions may need to
occur.
This brought it down to about 6-7 seconds.