Split up bootstrap tasks and submit individual ones to the executor. #29
Conversation
|
This bombards the process with hundreds of threads (I think I saw it go over 1k). That is why I did what I did in my PR. MC is using a Cached Thread Pool. Unless you change that on MC, this is not good. Now, overall I do prefer the cleaner approach here, but really needs clarity that it needs to use a queued executor instead. |
|
Can confirm, 1.13.2 pre 1 creates over 1000 threads at startup (for reference: 1.13.1 needs about 50). This really lags out some systems completly. |
As mentioned in Mojang#29, submitting all tasks to the executor implies that the executor will have limited # of threads. But if used with a cached thread pool, we will easily hit 1k threads+ This manually splits the work based on core count to a reasonable split rate, and then if the submitter wants to limit threads even more, it can pass an executor that limits thread count.
|
Just to mark this as a reference, this change introduced 2 bugs which will kill the game on old hardware (below minimum requirements, but generally dual cores with no SMT/HT available). https://bugs.mojang.com/browse/MC-137353 |
|
When opening 1.13 my computer does 5fps causing other programs to also lag or crash. |
Same as #28, but without manual task splitting, since the executor is doing that.