Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: user onboarding flow #426

Merged
merged 16 commits into from
Mar 3, 2023
Merged

chore: user onboarding flow #426

merged 16 commits into from
Mar 3, 2023

Conversation

120EE0692
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

Fixes

Description

Please describe your pull request.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@120EE0692 120EE0692 self-assigned this Feb 8, 2023
@120EE0692 120EE0692 added enhancement New feature or request wip Work In Progress labels Feb 8, 2023
@120EE0692 120EE0692 requested a review from rutajdash February 8, 2023 10:17
rutajdash
rutajdash requested changes Feb 8, 2023
View reviewed changes
client/src/components/onboarding/stages/NewsletterSignup.js

//context
import authContext from '../../../context/auth/AuthContext';

function VerifyEmail(props) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this named Verify Email?

client/src/components/onboarding/stages/NewsletterSignup.js
onClick={onNext}
>
Skip
skip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the case change?

client/src/graphql/mutations/user/updateUserTopics.js Outdated

const updateUserTopics = gql`
mutation UpdateUserTopics(
$updateUserTopicsId: ID!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this name, why not just ID or userId?

client/src/graphql/mutations/user/newsLetterSubscription.js Outdated
import { gql } from '@apollo/client';

const newsLetterSubscription = gql`
mutation ($newsletterSubscriptionId: ID!, $flag: Boolean!) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this name, why not just ID or userId?

client/src/graphql/mutations/user/addUserPicStorePath.js Outdated
import { gql } from '@apollo/client';

const addUserPicStorePath = gql`
mutation ($addUserPicStorePathId: ID!, $storePath: String!) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this name, why not just ID or userId?

client/src/context/auth/AuthState.js Outdated
});
} catch (err) {
console.log(err);
}
} else {
push('/');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not call this here, call this in the onboarding page flow instead. This login function may be used in other places where we would want to redirect differently.

client/src/components/onboarding/stages/Welcome.js
Comment on lines 24 to +25
loginWithToken(response.credential);
// onNext();
onNext();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause the flow to move ahead before the loginWithToken function has completed. That can raise complications.

@rutajdash
Copy link
Member

@120EE0692 add a sort of loading interstitial in the onboarding flow. It will be shown after the google sign up animation has completed till our media upload and mutations have completed.

@120EE0692 120EE0692 requested a review from rutajdash February 12, 2023 09:54
@rutajdash rutajdash changed the base branch from main to feat/onboarding February 14, 2023 11:04
@rutajdash rutajdash merged commit ff9125b into Monday-Morning:feat/onboarding Mar 3, 2023
120EE0692 added a commit that referenced this pull request Aug 26, 2023
@120EE0692 @rutajdash
@kanhaiya88628 @Anish-Sarawgi @Shurtu-gal @priyadarshini-silpa @anish-patro @Amal-Mohan-2002 @dependabot
feat: rebase with onboarding (#462)
66995b4 
* feat: get podcast data (#356)

* chore: fix pritter issue (#359)

* fix: prettier format check (#360)

* chore: fix prettier issue

* fix: prettier format check

* fix: photostory import issue  (#362)

* wip:PhotoStory to _Photostory

* wip: _Photostory to Photostory

* fix: update yarn.lock

* feat: enable dynamic spotify embed (#364)

* feat: enable spotify

* feat: show dynamic embded

* feat: basic integration of live page (#384)

* fix: add course list and disable till implementation

* fix: integrate data display

* chore: add session list

* feat: integrate live page

* feat(events): add calendar component for events page (#338)

* feat(events): add calendar component for events page

* style: add gaps between weekdays and the days box.

* feat: add a events page

* chore: rename about to event.

* fix: flicker

* fix: gap between day box and bottom

* fix: remove events page

* chore: add chart js

Co-authored-by: Kanhaiya <kagrawal88628@gmail.com>

* fix(photostory): add dynamic og meta tags (#378)

* fix(photostory): add dynamic og meta tags

* fix: modify og tag content url

* fix: modify og tag in article page

* fix: live and department links (#387)

* fix: live and departments links

* chore: prettier check

* fix: autocomplete search-bar flickering (#373)

* fix: search-bar animation

* fix: debounce time

* fix: article overflow due to link (#375)

* fix: link overflow

* fix: deprecated break-word

* fix: add null check for article (#370)

* fix: add null check for article

* fix: remove while loop

* fix: remove console.log

* fix: optional rendering of articles

* fix: consider all cases

* feat: add onboarding pagination (#388)

* feat: add onboarding pagination

* feat: smoothen mobile onboarding

* fix: button styling

* chore: remove redundant lines

* fix: set placed data in mobile screen (#386)

* style: fix styling issue in mobile screen

* fix: set placed data in mobile screen

* fix(article): fix table data and max width of article (#368)

* fix(table): fix missing data and max width

* style: add max width to the width

* feat(guide): add mini print carousel (#374)

* feat(guide): add mini print carousel

* fix: add link in mobile view

* fix: back button routing in healthInfo Page

* chore: redirect live page (#391)

* Merge branch 'main' into guide-miniPrint

* chore: reduce no. of state

* fix: remove coming soon

Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>

* fix: handle null contributions (#396)

* fix: handle null contributions

* fix(portfolio): null contributions

* chore: change contribution message

* fix: alignment of table of content (#385)

* fix: alignment of table of content

* fix: alignment on mobile/tablet screens

* feat: temporarily remove cwc section (#408)

* fix: add sac posts (#409)

* chore: remove url hardcoding (#410)

* fix: og tags of portfolio (#400)

* fix: og tags of portfolio

* fix: og tags

* feat: add hall page (#401)

* Hall Images

* feat: Hall Info  Page

* fix: Hall Page Routing

* fix: Mobile view

* fix: Cleaning code

* Fix: Formating

* Fix: Placeholder change

* fix(guide): add icon3 in option.js (#420)

* fix: auth key errors (#411)

* chore: upgrade packages to latest minor-patch (#423)

* chore(deps): bump loader-utils from 2.0.2 to 2.0.4 in /client (#312)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.2...v2.0.4)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump decode-uri-component from 0.2.0 to 0.2.2 in /client (#341)

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump json5 from 1.0.1 to 1.0.2 in /client (#392)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: user onboarding flow (#426)

* feat: redirect to home on skip onboarding

* chore: go to interested topic page

* feat(graphql): add add user store path mutation

* feat(graphql): add user interested topic mutation

* feat(graphql): add user news letter subscription mutation

* feat: integrate mutation to selected topics

* chore: change auth state

* feat: integrate newsletter subscricption

* chore:change user flow

* chore: change to user id

* chore: add category number in interested topics

* chore: change data type

* feat: add update user profile picture

* fix: user profile image path and mid

* feat: add get firebase user

* chore: change verify email flow

* feat: webmail authentication userflow (#440)

* feat: addNITRMail mutation

* feat: imagekit config file

* chore: update onboarding placeholders

* fix: standardise user mutations

* fix: add null check for firebaseToken

* feat: sign in and sign up auth user flows

* feat: implement sign in and signup auth user flows

* chore: rectify imports for used and unused

* feat: handle migrated accounts

* fix(migrated-user): add missing field

* fix: uncomment useRouter

* feat: user onboarding experience (#441)

* feat: add loading fallback

* feat: check already registered nitr mail

* fix: restore deleted imports

* feat: add default profile picture

* refactor: auth for server and client-side with middleware checks (#447)

* feat: create auth middleware for article pages

* chore(icons): use precise imports to reduce build

* fix: use defaultValue instead of selected

* fix: no div inside p

* fix: missing key prop in home

* chore: configure dev and prod for debugger

* refactor: apollo context provider

* refactor: apollo client for server side queries

* chore: update env sample for server key

* fix(middleware): retrieve correct cookies

* refactor: consume client side graphClient context

* refactor: merge auth context and state as provider

* refactor: remove redundant files

* fix(import): wrong path for checkNITRMail

* fix(auth-context-provider): typo in graphClient

* fix(auth-context): typo in variable name

* fix(auth-context): send email link prod switch

* feat: add sign in button (#425)

* feat: add sign in button

* fix

* fixed

* feat: add signIn button in mobile view

* feat: add signin and signout feature (#461)

* feat: add sign in button

* fix

* fixed

* feat: add signIn button in mobile view

* feat: add user avatar

* feat: add signin signout

---------

Co-authored-by: anish <anishkumarpatro03@gmail.com>
Co-authored-by: G.Anish Kumar Patro <105335549+anish-patro@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Rutaj Dash <33367546+rutajdash@users.noreply.github.com>
Co-authored-by: Kanhaiya Agrawal <83342480+kanhaiya88628@users.noreply.github.com>
Co-authored-by: Kanhaiya <kagrawal88628@gmail.com>
Co-authored-by: Anish Sarawgi <98693953+Anish-Sarawgi@users.noreply.github.com>
Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>
Co-authored-by: Silpa Priyadarshini <98985007+priyadarshini-silpa@users.noreply.github.com>
Co-authored-by: G.Anish Kumar Patro <105335549+anish-patro@users.noreply.github.com>
Co-authored-by: Amal Mohan <102766508+Amal-Mohan-2002@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: anish <anishkumarpatro03@gmail.com>
120EE0692 added a commit that referenced this pull request Oct 15, 2023
@120EE0692 @rutajdash
@Shurtu-gal @anish-patro @Anish-Sarawgi @dibendusahani @SUNNYKUMAR1232
feat: onboarding (#475)
57a6e02 
* chore: user onboarding flow (#426)

* feat: redirect to home on skip onboarding

* chore: go to interested topic page

* feat(graphql): add add user store path mutation

* feat(graphql): add user interested topic mutation

* feat(graphql): add user news letter subscription mutation

* feat: integrate mutation to selected topics

* chore: change auth state

* feat: integrate newsletter subscricption

* chore:change user flow

* chore: change to user id

* chore: add category number in interested topics

* chore: change data type

* feat: add update user profile picture

* fix: user profile image path and mid

* feat: add get firebase user

* chore: change verify email flow

* feat: webmail authentication userflow (#440)

* feat: addNITRMail mutation

* feat: imagekit config file

* chore: update onboarding placeholders

* fix: standardise user mutations

* fix: add null check for firebaseToken

* feat: sign in and sign up auth user flows

* feat: implement sign in and signup auth user flows

* chore: rectify imports for used and unused

* feat: handle migrated accounts

* fix(migrated-user): add missing field

* fix: uncomment useRouter

* feat: user onboarding experience (#441)

* feat: add loading fallback

* feat: check already registered nitr mail

* fix: restore deleted imports

* feat: add default profile picture

* refactor: auth for server and client-side with middleware checks (#447)

* feat: create auth middleware for article pages

* chore(icons): use precise imports to reduce build

* fix: use defaultValue instead of selected

* fix: no div inside p

* fix: missing key prop in home

* chore: configure dev and prod for debugger

* refactor: apollo context provider

* refactor: apollo client for server side queries

* chore: update env sample for server key

* fix(middleware): retrieve correct cookies

* refactor: consume client side graphClient context

* refactor: merge auth context and state as provider

* refactor: remove redundant files

* fix(import): wrong path for checkNITRMail

* fix(auth-context-provider): typo in graphClient

* fix(auth-context): typo in variable name

* fix(auth-context): send email link prod switch

* feat: add sign in button (#425)

* feat: add sign in button

* fix

* fixed

* feat: add signIn button in mobile view

* feat: add signin and signout feature (#461)

* feat: add sign in button

* fix

* fixed

* feat: add signIn button in mobile view

* feat: add user avatar

* feat: add signin signout

---------

Co-authored-by: anish <anishkumarpatro03@gmail.com>
Co-authored-by: G.Anish Kumar Patro <105335549+anish-patro@users.noreply.github.com>

* fix: missing pagination component (#469)

* chore: rename pagination to _pagination

* chore: rename _pagination to Pagination

* fix: gsi call after script load (#472)

* chore: remove gsi script (#473)

* feat: rebase with main (#474)

* chore: update CC info 2023 (#451)

* feat(home): increase number of displayed articles on the home page (#453)

chore(home): increase display articles

* chore: delete repo docs (#455)

* chore: delete repo docs

* chore: format html templete

* fix(home): remove duplicate article in home page (#456)

* fix(photostory): optimise the state update in photostory (#444)

* fix(photostory): optimise the state update

* fix(photostory): update right side image in carousel

* chore: update sac info page (#467)

* fix: search bar (#460)

* fix: search bar

* fix: serach bar

* fix: search bar

---------

Co-authored-by: Anish Sarawgi <98693953+Anish-Sarawgi@users.noreply.github.com>
Co-authored-by: Dibendu Sahani <112952404+dibendusahani@users.noreply.github.com>
Co-authored-by: SUNNY KUMAR <123469525+SUNNYKUMAR1232@users.noreply.github.com>

---------

Co-authored-by: Rutaj Dash <33367546+rutajdash@users.noreply.github.com>
Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>
Co-authored-by: G.Anish Kumar Patro <105335549+anish-patro@users.noreply.github.com>
Co-authored-by: anish <anishkumarpatro03@gmail.com>
Co-authored-by: Anish Sarawgi <98693953+Anish-Sarawgi@users.noreply.github.com>
Co-authored-by: Dibendu Sahani <112952404+dibendusahani@users.noreply.github.com>
Co-authored-by: SUNNY KUMAR <123469525+SUNNYKUMAR1232@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutajdash rutajdash Awaiting requested review from rutajdash

Assignees

@120EE0692 120EE0692

Labels
enhancement New feature or request wip Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@120EE0692 @rutajdash